Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread haosdent huang
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/#review127467 --- Ship it! Ship It! - Kevin Klues On April 6, 2016, 9:30

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread Michael Park
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/ --- (Updated April 6, 2016, 9:30 p.m.) Review request for mesos, Joerg Schad and

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-06 Thread haosdent huang
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/#review127228 --- Patch looks great! Reviews applied: [45767, 45768] Passed

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Kevin Klues
> On April 5, 2016, 8:01 p.m., Kevin Klues wrote: > > support/hooks/commit-msg, line 20 > > > > > > You should probably quote the $LINE variable here. You should also use > > a single "=", not "==". The double

Re: Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/#review127198 --- support/hooks/commit-msg (line 20)

Review Request 45768: Fixed commit message hook to skip over the commented lines.

2016-04-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45768/ --- Review request for mesos, Joerg Schad and Vinod Kone. Bugs: MESOS-5126