Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-10 Thread haosdent huang 


> On April 7, 2016, 2:13 a.m., haosdent huang wrote:
> > docs/attributes-resources.md, line 40
> > 
> >
> > `whole number values` means `natural number` here?
> 
> Kevin Klues wrote:
> Whole numbers are *almost* the same as natural numbers, with one 
> exception -- they include the number 0. We include 0, so whole nhmbers is the 
> right term here.

Thank you very much for your explanation. I always think natural number 
contains 0 before, did't realize there are two versions of natual number. 
https://en.wikipedia.org/wiki/Natural_number
>Some authors begin the natural numbers with 0, corresponding to the 
>non-negative integers 0, 1, 2, 3, …, 

Whole number is more exactly.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-08 Thread Ben Mahler 


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-08 Thread Ben Mahler 


> On April 7, 2016, 2:13 a.m., haosdent huang wrote:
> > docs/attributes-resources.md, line 99
> > 
> >
> > How about sort it by alphabetically?
> 
> Kevin Klues wrote:
> The only reason I didn't sort alphabetically was because these resources 
> don't seem to be ordered alphabetically anywhere else (`disk` always seems to 
> come *after* `mem`).  Since `gpus` are pretty similar to `cpus` in their 
> semantics, I decided to place them next to them in the order here.  We can 
> wait to see what Ben thinks.

After "cpus" sounds good to me since it's already not alphabetical.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-08 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127889
---


Ship it!




Ship It!

- Ben Mahler


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-08 Thread Kevin Klues 


> On April 7, 2016, 2:13 a.m., haosdent huang wrote:
> > docs/attributes-resources.md, line 40
> > 
> >
> > `whole number values` means `natural number` here?

Whole numbers are *almost* the same as natural numbers, with one exception -- 
they include the number 0. We include 0, so whole nhmbers is the right term 
here.


> On April 7, 2016, 2:13 a.m., haosdent huang wrote:
> > docs/attributes-resources.md, line 99
> > 
> >
> > How about sort it by alphabetically?

The only reason I didn't sort alphabetically was because these resources don't 
seem to be ordered alphabetically anywhere else (`disk` always seems to come 
*after* `mem`).  Since `gpus` are pretty similar to `cpus` in their semantics, 
I decided to place them next to them in the order here.  We can wait to see 
what Ben thinks.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/#review127534
---




docs/attributes-resources.md (line 40)


`whole number values` means `natural number` here?



docs/attributes-resources.md (line 99)


How about sort it by alphabetically?


- haosdent huang


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45855/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5135
> https://issues.apache.org/jira/browse/MESOS-5135
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated docs to include references to GPUs as a first class resource.
> 
> 
> Diffs
> -
> 
>   docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
>   docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 
> 
> Diff: https://reviews.apache.org/r/45855/diff/
> 
> 
> Testing
> ---
> 
> Looked at regenerated website and it seems to include the new documentation 
> properly.
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-06 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45855/
---

Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Bugs: MESOS-5135
https://issues.apache.org/jira/browse/MESOS-5135


Repository: mesos


Description
---

Updated docs to include references to GPUs as a first class resource.


Diffs
-

  docs/attributes-resources.md 26468d962440560a6b4b35f51ca248ab059ec31f 
  docs/monitoring.md 76be32842e8b437fda40c8565a34ec4f8d8dfbcc 

Diff: https://reviews.apache.org/r/45855/diff/


Testing
---

Looked at regenerated website and it seems to include the new documentation 
properly.


Thanks,

Kevin Klues