Re: Review Request 45856: Fixed Nvidia GPU test build for namespace change of MasterDetector.

2016-04-08 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45856/#review127885
---


Ship it!




Ship It!

- Ben Mahler


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45856/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5138
> https://issues.apache.org/jira/browse/MESOS-5138
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed Nvidia GPU test build for namespace change of MasterDetector.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> 5565227bc0b18f1891265e6eff0c5a22a0c4ab86 
> 
> Diff: https://reviews.apache.org/r/45856/diff/
> 
> 
> Testing
> ---
> 
> make check -j
> 
> ```
> sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
> bin/mesos-tests.sh
> SUCCESS
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Re: Review Request 45856: Fixed Nvidia GPU test build for namespace change of MasterDetector.

2016-04-06 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45856/#review127541
---



Patch looks great!

Reviews applied: [45856]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 7, 2016, 1:54 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45856/
> ---
> 
> (Updated April 7, 2016, 1:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.
> 
> 
> Bugs: MESOS-5138
> https://issues.apache.org/jira/browse/MESOS-5138
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed Nvidia GPU test build for namespace change of MasterDetector.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
> 5565227bc0b18f1891265e6eff0c5a22a0c4ab86 
> 
> Diff: https://reviews.apache.org/r/45856/diff/
> 
> 
> Testing
> ---
> 
> make check -j
> 
> ```
> sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
> bin/mesos-tests.sh
> SUCCESS
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>



Review Request 45856: Fixed Nvidia GPU test build for namespace change of MasterDetector.

2016-04-06 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45856/
---

Review request for mesos, Ben Mahler, Rob Todd, and Vikrama Ditya.


Bugs: MESOS-5138
https://issues.apache.org/jira/browse/MESOS-5138


Repository: mesos


Description
---

Fixed Nvidia GPU test build for namespace change of MasterDetector.


Diffs
-

  src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 
5565227bc0b18f1891265e6eff0c5a22a0c4ab86 

Diff: https://reviews.apache.org/r/45856/diff/


Testing
---

make check -j

```
sudo GTEST_FILTER="NvidiaGpuTest.ROOT_CGROUPS_NVIDIA_GPU_VerifyDeviceAccess" 
bin/mesos-tests.sh
SUCCESS
```


Thanks,

Kevin Klues