Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review148064 --- Given the way this review has evolved how about the following

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Sept. 7, 2016, 5:56 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review148024 --- Ship it! Minor things that I'll take care of when committing.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Sept. 6, 2016, 10:02 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On Sept. 1, 2016, 5:43 p.m., Jiang Yan Xu wrote: > > Updated the review with the following changes. > > > > I have already committed all 'resources*.cpp's so they are removed from the > > review. > > I moved the tests to /r/45962/ so the remainder of the current set of tests > > are in one

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Sept. 6, 2016, 6:13 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review147218 --- Updated the review with the following changes. I have already

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 31, 2016, 9:17 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On Aug. 25, 2016, 3:22 a.m., Jiang Yan Xu wrote: > > src/tests/sorter_tests.cpp, lines 773-779 > > > > > > Doesn't look like this block with `e` add much to the test coverage, > > remove it? I removed 'd' and

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 29, 2016, 7:21 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 25, 2016, 8:12 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 25, 2016, 4:14 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review146046 --- Comments mainly on tests (which I didn't look at earlier).

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On Aug. 12, 2016, 5:44 p.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 628 > > > > > > Move the check blow into the loop? > > > > ``` > > // Master would only allow

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 13, 2016, 12:57 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review144723 --- Skipped tests again but will pick them up soon as we are

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 30, 2016, 7:03 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review143893 --- src/master/master.cpp (line 3936)

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 28, 2016, 10:44 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On July 26, 2016, 4:06 p.m., Jiang Yan Xu wrote: > > src/master/master.hpp, lines 817-822 > > > > > > As commented below, I realized that we may not need this. We shouldn't > > calculate total task resources as

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review143040 --- Haven't commented on tests. Will look at them together with other

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 19, 2016, 10:52 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 18, 2016, 2:31 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

- Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review141305 --- On July 17, 2016, 6:28 p.m., Anindya Sinha wrote: >

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On July 12, 2016, 7:26 a.m., Jiang Yan Xu wrote: > > Adding to the previous partial review after discussion. > > > > ## Invariant checking and documentation > > > > An overall comment is that I think since we keep track of shared resource > > across Master, allocator and sorter, each for a

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 17, 2016, 6:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On July 11, 2016, 6:17 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp, lines 3499-3502 > > > > > > `task.has_executor()` doesn't always lead to additional resources being > > used/charged against the

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review141757 --- Adding to the previous partial review after discussion. ##

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review141305 --- Partial review. Let's discuss first. src/master/master.cpp

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 7, 2016, 3:44 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 457-467 > > > > > > For this we need to > > > > 1. Run existing benchmarks to see how much

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > src/master/allocator/sorter/drf/sorter.cpp, lines 457-467 > > > > > > For this we need to > > > > 1. Run existing benchmarks to see how much

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated July 1, 2016, 10:28 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > A high level comment is that when we are making significant changes to the > > allocator we have to measure the performance implication both when clusters > > don't use this feature and when clusters do in benchmarks. +1. Will do. -

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On June 14, 2016, 10:50 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, line 1773 > > > > > > Make sure we add this to the tests. > > > > So now the shared persistent volume could look like

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated June 23, 2016, 1:27 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review136970 --- A high level comment is that when we are making significant

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated June 13, 2016, 7:20 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

> On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote: > > Looks like the SHARE and UNSHARE operations are not in this patch? Yes that is correct. > On May 11, 2016, 3:49 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, line 1328 > >

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated May 22, 2016, 7:11 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review129838 --- Looks like the SHARE and UNSHARE operations are not in this

Re: Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan

Review Request 45961: Support sharing of resources through reference counting of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4431