Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

2016-06-17 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46025/#review138320 --- Ship it! Ship It! - Benjamin Mahler On June 16, 2016, 8:55 a

Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

2016-06-16 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46025/ --- (Updated June 16, 2016, 8:55 a.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

2016-06-16 Thread Neil Conway
> On April 11, 2016, 9:43 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp, lines 353-376 > > > > > > One question I have looking at this is whether we would benefit from > > more explicit struct

Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

2016-04-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46025/#review128259 --- Looks good, just some food for thought and a question related to t

Review Request 46025: Clarified comments on socket data structures in SocketManager.

2016-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46025/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --