Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46025/#review138320
---


Ship it!




Ship It!

- Benjamin Mahler


On June 16, 2016, 8:55 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46025/
> ---
> 
> (Updated June 16, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified comments on socket data structures in SocketManager.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> b4cdba6b0cd4f8f373f37118cd2e9d4955f2425a 
> 
> Diff: https://reviews.apache.org/r/46025/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46025/
---

(Updated June 16, 2016, 8:55 a.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Rebase, tweaks for `dispose` commentary.


Repository: mesos


Description
---

Clarified comments on socket data structures in SocketManager.


Diffs (updated)
-

  3rdparty/libprocess/src/process.cpp b4cdba6b0cd4f8f373f37118cd2e9d4955f2425a 

Diff: https://reviews.apache.org/r/46025/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

[Neil Conway]

> On April 11, 2016, 9:43 p.m., Benjamin Mahler wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 353-376
> > 
> >
> > One question I have looking at this is whether we would benefit from 
> > more explicit structure here:
> > 
> > ```
> > struct
> > {
> >   map sockets;
> >   map addresses;
> >   set dispose;
> >   map temps;
> >   map persists;
> >   map> outgoing;
> > } outbound;
> > 
> > struct
> > {
> >   map sockets;
> > } inbound;
> > ```
> > 
> > This assumes we don't need to track both inbound and outbound within 
> > the same map. From a quick glance at the code I can't see any reason to 
> > store them in the same map but perhaps I'm missing something.
> > 
> > There seems to be potential for significant consolidation of the 
> > outbond structures as well.

You could certainly reorganize the libprocess data structures significantly, 
but I'd prefer to defer that to later. Happy to open a JIRA if you'd like.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46025/#review128259
---


On April 11, 2016, 2:35 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46025/
> ---
> 
> (Updated April 11, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified comments on socket data structures in SocketManager.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/46025/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 46025: Clarified comments on socket data structures in SocketManager.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46025/#review128259
---



Looks good, just some food for thought and a question related to the 
relationship between `dispose` and `temps`.


3rdparty/libprocess/src/process.cpp (lines 353 - 376)


One question I have looking at this is whether we would benefit from more 
explicit structure here:

```
struct
{
  map sockets;
  map addresses;
  set dispose;
  map temps;
  map persists;
  map> outgoing;
} outbound;

struct
{
  map sockets;
} inbound;
```

This assumes we don't need to track both inbound and outbound within the 
same map. From a quick glance at the code I can't see any reason to store them 
in the same map but perhaps I'm missing something.

There seems to be potential for significant consolidation of the outbond 
structures as well.



3rdparty/libprocess/src/process.cpp (lines 356 - 358)


Why didn't you update this comment? Is the set of values within `temps` 
equivalent to `dispose`? Would be great to explain the distinction here.


- Ben Mahler


On April 11, 2016, 2:35 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46025/
> ---
> 
> (Updated April 11, 2016, 2:35 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified comments on socket data structures in SocketManager.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 
> 
> Diff: https://reviews.apache.org/r/46025/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 46025: Clarified comments on socket data structures in SocketManager.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46025/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Clarified comments on socket data structures in SocketManager.


Diffs
-

  3rdparty/libprocess/src/process.cpp 5e9dcfdc52f3a8223bc43af149b8e1f5dbdf5b0a 

Diff: https://reviews.apache.org/r/46025/diff/


Testing
---


Thanks,

Neil Conway