Re: Review Request 46104: Made use of random container IDs in tests.

2016-05-30 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46104/#review135578
---



Patch looks great!

Reviews applied: [46620, 46814, 46621, 47078, 46003, 46004, 45562, 47952, 46104]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On May 30, 2016, 11:54 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46104/
> ---
> 
> (Updated May 30, 2016, 11:54 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos containerizer tests previously used a fixed
> container ID; this patch makes use of a random UUID
> instead.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
> 
> Diff: https://reviews.apache.org/r/46104/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 46104: Made use of random container IDs in tests.

2016-05-30 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46104/
---

(Updated May 30, 2016, 11:54 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Changed dependency.


Repository: mesos


Description
---

The Mesos containerizer tests previously used a fixed
container ID; this patch makes use of a random UUID
instead.


Diffs
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 

Diff: https://reviews.apache.org/r/46104/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann



Re: Review Request 46104: Made use of random container IDs in tests.

2016-05-11 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46104/#review132775
---


Ship it!




Ship It!

- Vinod Kone


On April 12, 2016, 5:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46104/
> ---
> 
> (Updated April 12, 2016, 5:52 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos containerizer tests previously used a fixed
> container ID; this patch makes use of a random UUID
> instead.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
> 
> Diff: https://reviews.apache.org/r/46104/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 46104: Made use of random container IDs in tests.

2016-04-12 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46104/#review128530
---



Patch looks great!

Reviews applied: [46003, 46005, 46004, 45562, 46104]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 12, 2016, 5:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46104/
> ---
> 
> (Updated April 12, 2016, 5:52 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The Mesos containerizer tests previously used a fixed
> container ID; this patch makes use of a random UUID
> instead.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
> 
> Diff: https://reviews.apache.org/r/46104/diff/
> 
> 
> Testing
> ---
> 
> `sudo make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 46104: Made use of random container IDs in tests.

2016-04-12 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46104/
---

(Updated April 12, 2016, 5:52 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description (updated)
---

The Mesos containerizer tests previously used a fixed
container ID; this patch makes use of a random UUID
instead.


Diffs
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 

Diff: https://reviews.apache.org/r/46104/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann



Review Request 46104: Made use of random container IDs in tests.

2016-04-12 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46104/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Made use of random container IDs in tests.


Diffs
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
09742ff21513dc2570684d384b257868dd57a9ce 

Diff: https://reviews.apache.org/r/46104/diff/


Testing
---

`sudo make check`


Thanks,

Greg Mann