Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review129824 --- Ship it! Thanks Guangya. It looks to me overall. I did a few

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 20, 2016, 10:14 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 15, 2016, 3:27 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-15 Thread Guangya Liu
> On 四月 14, 2016, 6:33 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp, lines > > 72-73 > > > > > > How about moving "' used by volume isolator" to the second line?

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review129023 ---

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review128942 ---

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 14, 2016, 1:40 p.m.) Review request for mesos, David vonThenen,

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- (Updated 四月 14, 2016, 6:06 a.m.) Review request for mesos, David vonThenen,

Re: Review Request 46180: Implemented create() for docker volume isolator.

2016-04-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/#review128819 --- Patch looks great! Reviews applied: [45214, 45217, 45270, 45360,

Review Request 46180: Implemented create() for docker volume isolator.

2016-04-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46180/ --- Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and