Re: Review Request 46193: Stout:[2/2] Added `systems_tests.cpp`.

2016-04-14 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46193/#review129007
---


Ship it!




Ship It!

- Michael Park


On April 14, 2016, 8:28 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46193/
> ---
> 
> (Updated April 14, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
> https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[2/2] Added `systems_tests.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 217283cd3ce6df699b63dc5b8fb3aab0c6debd04 
> 
> Diff: https://reviews.apache.org/r/46193/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 46193: Stout:[2/2] Added `systems_tests.cpp`.

2016-04-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46193/#review128865
---



Bad patch!

Reviews applied: [46193, 46192, 46191, 46015, 46014, 46013, 46012, 43985]

Failed command: ./support/apply-review.sh -n -r 43985

Error:
2016-04-14 09:51:51 URL:https://reviews.apache.org/r/43985/diff/raw/ 
[1185/1185] -> "43985.patch" [1]
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/sendfile.hpp:36:  
Missing space after ,  [whitespace/comma] [3]
Total errors found: 1
Checking 1 files

Full log: https://builds.apache.org/job/mesos-reviewbot/12521/console

- Mesos ReviewBot


On April 14, 2016, 8:28 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46193/
> ---
> 
> (Updated April 14, 2016, 8:28 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Bugs: MESOS-4470
> https://issues.apache.org/jira/browse/MESOS-4470
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[2/2] Added `systems_tests.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> 217283cd3ce6df699b63dc5b8fb3aab0c6debd04 
> 
> Diff: https://reviews.apache.org/r/46193/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 46193: Stout:[2/2] Added `systems_tests.cpp`.

2016-04-14 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46193/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Bugs: MESOS-4470
https://issues.apache.org/jira/browse/MESOS-4470


Repository: mesos


Description
---

Stout:[2/2] Added `systems_tests.cpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/Makefile.am 
217283cd3ce6df699b63dc5b8fb3aab0c6debd04 

Diff: https://reviews.apache.org/r/46193/diff/


Testing
---


Thanks,

Alex Clemmer