Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated May 10, 2016, 2:14 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated May 10, 2016, 1:48 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review132324 --- Ship it! Modulo comments. - Ben Mahler On May 7, 2016, 1:03

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review132308 --- src/launcher/http_command_executor.cpp (line 620)

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

> On May 5, 2016, 8:25 p.m., Ben Mahler wrote: > > src/launcher/http_command_executor.cpp, lines 644-645 > > > > > > How about: > > > > ``` > > cout << "Received a new kill policy grace period of <<

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review132142 --- Bad patch! Reviews applied: [46325, 46323, 46322, 46491, 46321]

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated May 7, 2016, 1:03 p.m.) Review request for mesos, Ben Mahler and Qian

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated May 7, 2016, 12:59 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

> On May 5, 2016, 8:25 p.m., Ben Mahler wrote: > > src/launcher/http_command_executor.cpp, lines 622-625 > > > > > > The second bullet isn't really a limitation here right? > > > > Since we track when the

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

> On May 5, 2016, 8:25 p.m., Ben Mahler wrote: > > src/launcher/http_command_executor.cpp, lines 569-575 > > > > > > It looks like we have to re-assign kill_policy! Otherwise, if kill is > > called internally (e.g.

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review131920 --- Patch looks great! Reviews applied: [46321, 46491, 46322, 46323,

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review131890 --- src/launcher/http_command_executor.cpp (lines 569 - 575)

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated May 5, 2016, 3:39 p.m.) Review request for mesos, Ben Mahler and Qian

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review130116 --- Patch looks great! Reviews applied: [46321, 46491, 46322, 46323,

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

> On April 21, 2016, 9:56 p.m., Ben Mahler wrote: > > Could you pull out the 'killed' bug fix? Any reason it's bundled in this > > patch? Will do. - Alexander --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 22, 2016, 2:46 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

> On April 21, 2016, 9:56 p.m., Ben Mahler wrote: > > src/launcher/http_command_executor.cpp, lines 172-176 > > > > > > Wrap at the paren: > > > > ``` > > kill(event.kill().task_id(), > >

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review129937 --- Could you pull out the 'killed' bug fix? Any reason it's bundled

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 21, 2016, 2:28 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 21, 2016, 2:11 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- (Updated April 21, 2016, 2:06 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/#review129344 --- Patch looks great! Reviews applied: [46321, 46322, 46323, 46324,

Review Request 46325: Updated HTTP command executor to support kill policy in Kill event.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46325/ --- Review request for mesos, Ben Mahler and Qian Zhang. Bugs: MESOS-4908