Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/#review148877 --- Closing this review as Benjamin has followed up with separate reviews. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On May 26, 2016, 3:01 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46371/ > --- > > (Updated May 26, 2016, 3:01 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added basic tests for capabilities API. > > > Diffs > - > > src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 > src/tests/capabilities_test_helper.hpp PRE-CREATION > src/tests/capabilities_test_helper.cpp PRE-CREATION > src/tests/capabilities_test_helper_main.cpp PRE-CREATION > src/tests/capabilities_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46371/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Jojy Varghese > >
Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated May 26, 2016, 3:01 p.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Added basic tests for capabilities API. Diffs (updated) - src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated May 25, 2016, 6:39 p.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Added basic tests for capabilities API. Diffs (updated) - src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated May 11, 2016, 4:34 a.m.) Review request for mesos and Jie Yu. Changes --- rebased. Repository: mesos Description --- Added basic tests for capabilities API. Diffs (updated) - src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated May 5, 2016, 9:01 p.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Added basic tests for capabilities API. Diffs (updated) - src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/#review129827 --- Patch looks great! Reviews applied: [46369, 46370, 46371] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 20, 2016, 7:12 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46371/ > --- > > (Updated April 20, 2016, 7:12 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added basic tests for capabilities API. > > > Diffs > - > > src/Makefile.am 08d5279bbc0c763255fda3c3360d8f24f41bccda > src/tests/capabilities_test_helper.hpp PRE-CREATION > src/tests/capabilities_test_helper.cpp PRE-CREATION > src/tests/capabilities_test_helper_main.cpp PRE-CREATION > src/tests/capabilities_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46371/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Jojy Varghese > >
Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- (Updated April 20, 2016, 7:12 p.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Added basic tests for capabilities API. Diffs (updated) - src/Makefile.am 08d5279bbc0c763255fda3c3360d8f24f41bccda src/tests/capabilities_test_helper.hpp PRE-CREATION src/tests/capabilities_test_helper.cpp PRE-CREATION src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese
Re: Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/#review129649 --- Bad patch! Reviews applied: [46371, 46370, 46369] Failed command: ./support/apply-review.sh -n -r 46370 Error: 2016-04-19 23:35:36 URL:https://reviews.apache.org/r/46370/diff/raw/ [17675/17675] -> "46370.patch" [1] error: patch failed: src/Makefile.am:858 error: src/Makefile.am: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/12619/console - Mesos ReviewBot On April 19, 2016, 5:03 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46371/ > --- > > (Updated April 19, 2016, 5:03 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > Added basic tests for capabilities API. > > > Diffs > - > > src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 > src/tests/capabilities_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46371/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Jojy Varghese > >
Review Request 46371: Added basic tests for capabilities API.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46371/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- Added basic tests for capabilities API. Diffs - src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese
