Re: Review Request 46744: Added AuthN support to long lived framework.

2016-04-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46744/#review130829
---



Patch looks great!

Reviews applied: [46743, 46744]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 27, 2016, 5:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46744/
> ---
> 
> (Updated April 27, 2016, 5:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 4c9ba5fea2cc1eafa8ee942a505038c9b109ff65 
> 
> Diff: https://reviews.apache.org/r/46744/diff/
> 
> 
> Testing
> ---
> 
> make check + tested that AuthN works.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 46744: Added AuthN support to long lived framework.

2016-04-27 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46744/#review130828
---


Ship it!




Ship It!

- Vinod Kone


On April 27, 2016, 5:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46744/
> ---
> 
> (Updated April 27, 2016, 5:39 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 4c9ba5fea2cc1eafa8ee942a505038c9b109ff65 
> 
> Diff: https://reviews.apache.org/r/46744/diff/
> 
> 
> Testing
> ---
> 
> make check + tested that AuthN works.
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 46744: Added AuthN support to long lived framework.

2016-04-27 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46744/
---

Review request for mesos, Gilbert Song and Vinod Kone.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/examples/long_lived_framework.cpp 
4c9ba5fea2cc1eafa8ee942a505038c9b109ff65 

Diff: https://reviews.apache.org/r/46744/diff/


Testing
---

make check + tested that AuthN works.


Thanks,

Anand Mazumdar