Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated May 13, 2016, 4:09 a.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Michael Park.


Changes
---

benm's comments. NNFR.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

In addition to updating the code for the new signature, deprecation
warnings are also printed when loading deprecated flag names/aliases.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
c62fe3ee6ae06536cbb89ea208b669790efe4b39 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-05-12 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/#review133003
---


Fix it, then Ship it!





src/cli/execute.cpp (line 644)


`->` here and everywhere else


- Ben Mahler


On May 12, 2016, 10:43 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46815/
> ---
> 
> (Updated May 12, 2016, 10:43 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5370
> https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In addition to updating the code for the new signature, deprecation
> warnings are also printed when loading deprecated flag names/aliases.
> 
> 
> Diffs
> -
> 
>   src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
>   src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
>   src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
>   src/examples/dynamic_reservation_framework.cpp 
> 4ad5f4b846052ec9a2067a5ce21fb017f681debf 
>   src/examples/load_generator_framework.cpp 
> b22a09e1749d4b523addacad99858d7b6bde3403 
>   src/examples/long_lived_framework.cpp 
> 1740d7cb747d179d06e75153aa334b29e9cdf3c0 
>   src/examples/no_executor_framework.cpp 
> f578edfd99f3b7adf19cf06eab20696532c7b67d 
>   src/examples/persistent_volume_framework.cpp 
> b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
>   src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
>   src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
>   src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
>   src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
>   src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
>   src/launcher/http_command_executor.cpp 
> c62fe3ee6ae06536cbb89ea208b669790efe4b39 
>   src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
>   src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
>   src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
>   src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
>   src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
>   src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
>   src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
>   src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
>   src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
>   src/slave/container_loggers/lib_logrotate.cpp 
> 1f228806da32832c9ca1ae4defcd1bdc154adc18 
>   src/slave/container_loggers/logrotate.cpp 
> 7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
>   src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
>   src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
>   src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 
> 
> Diff: https://reviews.apache.org/r/46815/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated May 12, 2016, 10:43 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated bug id.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

In addition to updating the code for the new signature, deprecation
warnings are also printed when loading deprecated flag names/aliases.


Diffs
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
c62fe3ee6ae06536cbb89ea208b669790efe4b39 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated May 12, 2016, 8:54 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description (updated)
---

In addition to updating the code for the new signature, deprecation
warnings are also printed when loading deprecated flag names/aliases.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp d60addcbe4a1869945ce42f4bb4b1e80e3f29f19 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp fa4a89e97b0c427b4595a6adebc397aeb5bfaaa5 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
c62fe3ee6ae06536cbb89ea208b669790efe4b39 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 2d1bd554d8bbbf98ac1c1a7b196c9ab6185e38b9 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp 66aea8c79be29678e16359f48452a41e5b473aa2 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-04-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated April 30, 2016, 3:44 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated mesos to work with new `flags.load()` signature.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-04-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated April 29, 2016, 7:09 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

fixed flags::load() in files that were not compiled in my local machine.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated mesos to work with new `flags.load()` signature.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/local/main.cpp 51bbdfbd18650fbbe9fede4aca3feb2f43beca72 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/lib_logrotate.cpp 
1f228806da32832c9ca1ae4defcd1bdc154adc18 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-04-28 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

(Updated April 29, 2016, 6:47 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

add a new dependency.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated mesos to work with new `flags.load()` signature.


Diffs (updated)
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 46815: Updated mesos to work with new `flags.load()` signature.

2016-04-28 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46815/
---

Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated mesos to work with new `flags.load()` signature.


Diffs
-

  src/cli/execute.cpp 4711e80314e2fc4cde077bebd9a8167324c3254e 
  src/cli/resolve.cpp 23bb0f156fb07aed54ef225b0a5438a1427631bf 
  src/examples/dynamic_reservation_framework.cpp 
4ad5f4b846052ec9a2067a5ce21fb017f681debf 
  src/examples/load_generator_framework.cpp 
b22a09e1749d4b523addacad99858d7b6bde3403 
  src/examples/long_lived_framework.cpp 
1740d7cb747d179d06e75153aa334b29e9cdf3c0 
  src/examples/no_executor_framework.cpp 
f578edfd99f3b7adf19cf06eab20696532c7b67d 
  src/examples/persistent_volume_framework.cpp 
b4faa0ee25dc3a72c17ef2b0640a3695423ef79a 
  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 
  src/exec/exec.cpp a2e6d86fd0b1f3d688d17296151db74bcb9b3418 
  src/executor/executor.cpp c7187ea2f0685b6553356acbea90a63f643c0713 
  src/health-check/main.cpp 98ea5d3675f088e3a341037dcee92695e4857999 
  src/launcher/executor.cpp 9f1d2168bc4ddbce1bcd25ff38dc1c34714eb28b 
  src/launcher/fetcher.cpp d323f6341ab8367eeb456c9f399395293960fb66 
  src/launcher/http_command_executor.cpp 
0b4136c040ec9cf585c0d38f8471495a855cd640 
  src/local/local.cpp 1c679ecb486cb3d6184ec9a941f2ac5dbd2bcc1f 
  src/log/tool/benchmark.cpp 8981ea82735f3a1149aa777a62960582fea67a4d 
  src/log/tool/initialize.cpp bd1e9ef1922ae972a5999b6e7412e08eac92c1ac 
  src/log/tool/read.cpp b9e90e44c8cd7351767e523af338d8c662e0848c 
  src/log/tool/replica.cpp e3661df858705132685b0c584c1adc716099bc30 
  src/master/main.cpp 23149d5511d1556f1a885d01ea9380a9669fa8c5 
  src/sched/sched.cpp 4693d0dc09afc3ddbbf34e166579b6a6d71c3e38 
  src/scheduler/scheduler.cpp 7d83f3c3ffdb0f4bac67af5b156f69302abe7999 
  src/slave/container_loggers/logrotate.cpp 
7d36c052ff7a180b45ca265fb7ff4c6900d98d64 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
  src/tests/main.cpp c3ccf918c781bdb25b220c7ef3efa7d3b7c88c91 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 

Diff: https://reviews.apache.org/r/46815/diff/


Testing
---

make check


Thanks,

Vinod Kone