Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 13, 2016, 4:09 a.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and Michael Park.


Changes
---

benm's comments. NNFR.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

No functional changes.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/#review133002
---


Ship it!





3rdparty/libprocess/src/tests/subprocess_tests.cpp (line 613)


Can you add an expectation that there are no warnings?


- Ben Mahler


On May 12, 2016, 10:42 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46818/
> ---
> 
> (Updated May 12, 2016, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.
> 
> 
> Bugs: MESOS-5370
> https://issues.apache.org/jira/browse/MESOS-5370
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> No functional changes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 727e940f12643974de4ff2734fba431b285b5de3 
> 
> Diff: https://reviews.apache.org/r/46818/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 12, 2016, 10:42 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated bug id.


Bugs: MESOS-5370
https://issues.apache.org/jira/browse/MESOS-5370


Repository: mesos


Description
---

No functional changes.


Diffs
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 12, 2016, 8:54 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

updated description.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description (updated)
---

No functional changes.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-05-12 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated May 12, 2016, 8:46 p.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Changes
---

rebased.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated libprocess tests to work with the new `flag.load()` signature.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-04-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

(Updated April 30, 2016, 3:44 a.m.)


Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated libprocess tests to work with the new `flag.load()` signature.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone

Review Request 46818: Updated libprocess tests to work with the new `flag.load()` signature.

2016-04-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46818/
---

Review request for mesos, Ben Mahler, Greg Mann, and Michael Park.


Bugs: MESOS-5271
https://issues.apache.org/jira/browse/MESOS-5271


Repository: mesos


Description
---

Updated libprocess tests to work with the new `flag.load()` signature.


Diffs
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
727e940f12643974de4ff2734fba431b285b5de3 

Diff: https://reviews.apache.org/r/46818/diff/


Testing
---

make check


Thanks,

Vinod Kone