Re: Review Request 46868: Added authorization to '/metrics/snapshot'.

2016-05-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46868/
---

(Updated May 6, 2016, 9:15 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The '/metrics/snapshot' handler is updated to
authorize requests via an authorization callback
installed in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
25e8fcaeb9c71eaa43096165745e79c8198c139a 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 

Diff: https://reviews.apache.org/r/46868/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann



Re: Review Request 46868: Added authorization to '/metrics/snapshot'.

2016-05-01 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46868/
---

(Updated May 2, 2016, 12:01 a.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The '/metrics/snapshot' handler is updated to
authorize requests via an authorization callback
installed in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
25e8fcaeb9c71eaa43096165745e79c8198c139a 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 

Diff: https://reviews.apache.org/r/46868/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann



Re: Review Request 46868: Added authorization to '/metrics/snapshot'.

2016-05-01 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46868/
---

(Updated May 1, 2016, 10:43 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The '/metrics/snapshot' handler is updated to
authorize requests via an authorization callback
installed in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
25e8fcaeb9c71eaa43096165745e79c8198c139a 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 
  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 

Diff: https://reviews.apache.org/r/46868/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann



Review Request 46868: Added authorization to '/metrics/snapshot'.

2016-05-01 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46868/
---

Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

The '/metrics/snapshot' handler is updated to
authorize requests via an authorization callback
installed in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/metrics/metrics.hpp 
25e8fcaeb9c71eaa43096165745e79c8198c139a 
  3rdparty/libprocess/src/metrics/metrics.cpp 
65b58433158c51cebace9b591d4121e8d9a59ecc 

Diff: https://reviews.apache.org/r/46868/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann