Re: Review Request 46875: Some cleanup in weights_handler.cpp.
> On 六月 17, 2016, 1 p.m., Alexander Rukletsov wrote:
> > I beleive `request.body` is supposed to be the contents, and not the file,
> > right?
Just FYI, Alex, I have fixed this issue in https://reviews.apache.org/r/48680/
and it was merged today.
- Guangya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46875/#review138209
---
On 五月 1, 2016, 6:52 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46875/
> ---
>
> (Updated 五月 1, 2016, 6:52 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> There is no need to add () for request body as there is already
> '' for the message.
>
>
> Diffs
> -
>
> src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975
>
> Diff: https://reviews.apache.org/r/46875/diff/
>
>
> Testing
> ---
>
> Before fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON ('weight.json'): syntax error at
> line 1 near: weight.js
>
> After fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON 'weight.json': syntax error at
> line 1 near: weight.json
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46875: Some cleanup in weights_handler.cpp.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46875/#review138309
---
Ship it!
Ship It!
- Adam B
On April 30, 2016, 11:52 p.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46875/
> ---
>
> (Updated April 30, 2016, 11:52 p.m.)
>
>
> Review request for mesos, Adam B and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> There is no need to add () for request body as there is already
> '' for the message.
>
>
> Diffs
> -
>
> src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975
>
> Diff: https://reviews.apache.org/r/46875/diff/
>
>
> Testing
> ---
>
> Before fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON ('weight.json'): syntax error at
> line 1 near: weight.js
>
> After fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON 'weight.json': syntax error at
> line 1 near: weight.json
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46875: Some cleanup in weights_handler.cpp.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46875/#review138209
---
I beleive `request.body` is supposed to be the contents, and not the file,
right?
- Alexander Rukletsov
On May 1, 2016, 6:52 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46875/
> ---
>
> (Updated May 1, 2016, 6:52 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> There is no need to add () for request body as there is already
> '' for the message.
>
>
> Diffs
> -
>
> src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975
>
> Diff: https://reviews.apache.org/r/46875/diff/
>
>
> Testing
> ---
>
> Before fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON ('weight.json'): syntax error at
> line 1 near: weight.js
>
> After fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON 'weight.json': syntax error at
> line 1 near: weight.json
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 46875: Some cleanup in weights_handler.cpp.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46875/#review131266
---
Patch looks great!
Reviews applied: [46875]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose'
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On May 1, 2016, 6:52 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46875/
> ---
>
> (Updated May 1, 2016, 6:52 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> There is no need to add () for request body as there is already
> '' for the message.
>
>
> Diffs
> -
>
> src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975
>
> Diff: https://reviews.apache.org/r/46875/diff/
>
>
> Testing
> ---
>
> Before fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON ('weight.json'): syntax error at
> line 1 near: weight.js
>
> After fix:
> root@mesos002:~/test# curl -d weight.json -X PUT
> http://192.168.56.12:5050/weights
> Failed to parse update weights request JSON 'weight.json': syntax error at
> line 1 near: weight.json
>
>
> Thanks,
>
> Guangya Liu
>
>
Review Request 46875: Some cleanup in weights_handler.cpp.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46875/
---
Review request for mesos, Adam B and Alexander Rukletsov.
Repository: mesos
Description
---
There is no need to add () for request body as there is already
'' for the message.
Diffs
-
src/master/weights_handler.cpp 07cc9920ca61f3e6e9e5b8be37884ed6f0d4f975
Diff: https://reviews.apache.org/r/46875/diff/
Testing
---
Before fix:
root@mesos002:~/test# curl -d weight.json -X PUT
http://192.168.56.12:5050/weights
Failed to parse update weights request JSON ('weight.json'): syntax error at
line 1 near: weight.js
After fix:
root@mesos002:~/test# curl -d weight.json -X PUT
http://192.168.56.12:5050/weights
Failed to parse update weights request JSON 'weight.json': syntax error at line
1 near: weight.json
Thanks,
Guangya Liu
