Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46881/#review132532
---


Ship it!





src/common/http.cpp (lines 590 - 592)


Maybe move this closer to AuthorizationCallbacks declaration?


- Kapil Arya


On May 10, 2016, 4:38 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46881/
> ---
> 
> (Updated May 10, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Kapil Arya.
> 
> 
> Bugs: MESOS-5286
> https://issues.apache.org/jira/browse/MESOS-5286
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds an authorization callback to the
> generating function `CreateAuthorizationCallbacks`
> for the '/logging/toggle' endpoint.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 
> 
> Diff: https://reviews.apache.org/r/46881/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46881/
---

(Updated May 10, 2016, 8:38 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Change dependency.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds an authorization callback to the
generating function `CreateAuthorizationCallbacks`
for the '/logging/toggle' endpoint.


Diffs (updated)
-

  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 

Diff: https://reviews.apache.org/r/46881/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46881/
---

(Updated May 6, 2016, 9:17 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds an authorization callback to the
generating function `CreateAuthorizationCallbacks`
for the '/logging/toggle' endpoint.


Diffs (updated)
-

  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 

Diff: https://reviews.apache.org/r/46881/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Re: Review Request 46881: Added authorization callback for '/logging/toggle'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46881/
---

(Updated May 5, 2016, 1:45 p.m.)


Review request for mesos, Alexander Rojas and Kapil Arya.


Changes
---

Rebase.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds an authorization callback to the
generating function `CreateAuthorizationCallbacks`
for the '/logging/toggle' endpoint.


Diffs (updated)
-

  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 

Diff: https://reviews.apache.org/r/46881/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann

Review Request 46881: Added authorization callback for '/logging/toggle'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46881/
---

Review request for mesos, Alexander Rojas and Kapil Arya.


Bugs: MESOS-5286
https://issues.apache.org/jira/browse/MESOS-5286


Repository: mesos


Description
---

This patch adds an authorization callback to the
generating function `CreateAuthorizationCallbacks`
for the '/logging/toggle' endpoint.


Diffs
-

  src/common/http.cpp ccf386898130c966903cb5aae4eaffbc9b63ca1f 

Diff: https://reviews.apache.org/r/46881/diff/


Testing
---

`make check` on OSX.


Thanks,

Greg Mann