Re: Review Request 46923: Added framework failover timeout validation.

2016-05-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review133000 --- Patch looks great! Reviews applied: [46923] Passed command:

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132958 --- Ship it! Ship It! - Vinod Kone On May 11, 2016, 3:47 a.m.,

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-10 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 11, 2016, 3:47 a.m.) Review request for mesos, Guangya Liu, Kevin

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132571 --- src/master/master.hpp (line 929)

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132092 --- Patch looks great! Reviews applied: [46923] Passed command:

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 6, 2016, 12:09 p.m.) Review request for mesos, Guangya Liu, Kevin

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132017 --- src/master/master.cpp (line 1387)

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 6, 2016, 12:03 p.m.) Review request for mesos, Guangya Liu, Kevin

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review132003 --- Fix it, then Ship it! src/master/master.cpp (line 1386)

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131988 --- Patch looks great! Reviews applied: [46923] Passed command:

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-05 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 6, 2016, 3:18 a.m.) Review request for mesos, Guangya Liu, Kevin

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-05 Thread Jose Guilherme Vanz
> On May 4, 2016, 7:35 a.m., Neil Conway wrote: > > I notice that `Master::_exited` also checks that the `failover_timeout` is > > valid. Do you think it would be better to simplify that logic to assume > > that the `failover_timeout` is always valid? i.e., add a `CHECK` that it is > > valid

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131635 --- I notice that `Master::_exited` also checks that the

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131610 --- Patch looks great! Reviews applied: [46923] Passed command:

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 4, 2016, 12:31 a.m.) Review request for mesos, Kevin Sweeney and

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- (Updated May 4, 2016, 12:27 a.m.) Review request for mesos, Kevin Sweeney and

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131489 --- You can put `MESOS-1575` to the `bugs` column at right.

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131485 --- src/master/master.hpp (line 937)

Re: Review Request 46923: Added framework failover timeout validation.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/#review131467 --- Patch looks great! Reviews applied: [46923] Passed command:

Review Request 46923: Added framework failover timeout validation.

2016-05-02 Thread Jose Guilherme Vanz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46923/ --- Review request for mesos. Repository: mesos Description --- Frameworks