Re: Review Request 46990: Removed authorization from libprocess endpoint handlers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46990/ --- (Updated May 6, 2016, 9:21 p.m.) Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286 https://issues.apache.org/jira/browse/MESOS-5286 Repository: mesos Description --- The previous commit added authorization handling to `ProcessBase::visit`, so the authorization handlers in the endpoint code can be removed. Diffs - 3rdparty/libprocess/include/process/logging.hpp 651cb3736705124bec9e4366c0e7adc5d5b488f0 3rdparty/libprocess/include/process/metrics/metrics.hpp 25e8fcaeb9c71eaa43096165745e79c8198c139a 3rdparty/libprocess/src/logging.cpp ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 3rdparty/libprocess/src/metrics/metrics.cpp 65b58433158c51cebace9b591d4121e8d9a59ecc Diff: https://reviews.apache.org/r/46990/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann
Re: Review Request 46990: Removed authorization from libprocess endpoint handlers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46990/#review131783 --- Bad patch! Reviews applied: [46990, 46989, 46882, 46881, 46880, 46876, 46870, 46869, 46883, 46868, 46867, 46866] Failed command: ./support/apply-review.sh -n -r 46883 Error: 2016-05-05 04:58:11 URL:https://reviews.apache.org/r/46883/diff/raw/ [1105/1105] -> "46883.patch" [1] error: patch failed: src/common/http.cpp:589 error: src/common/http.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/12891/console - Mesos ReviewBot On May 4, 2016, 6:48 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46990/ > --- > > (Updated May 4, 2016, 6:48 p.m.) > > > Review request for mesos, Alexander Rojas and Kapil Arya. > > > Bugs: MESOS-5286 > https://issues.apache.org/jira/browse/MESOS-5286 > > > Repository: mesos > > > Description > --- > > The previous commit added authorization handling > to `ProcessBase::visit`, so the authorization > handlers in the endpoint code can be removed. > > > Diffs > - > > 3rdparty/libprocess/include/process/logging.hpp > 651cb3736705124bec9e4366c0e7adc5d5b488f0 > 3rdparty/libprocess/include/process/metrics/metrics.hpp > 25e8fcaeb9c71eaa43096165745e79c8198c139a > 3rdparty/libprocess/src/logging.cpp > ad7aa3aabbfc4a496e7e624a691a72e45c72e35d > 3rdparty/libprocess/src/metrics/metrics.cpp > 65b58433158c51cebace9b591d4121e8d9a59ecc > > Diff: https://reviews.apache.org/r/46990/diff/ > > > Testing > --- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
Review Request 46990: Removed authorization from libprocess endpoint handlers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46990/ --- Review request for mesos, Alexander Rojas and Kapil Arya. Bugs: MESOS-5286 https://issues.apache.org/jira/browse/MESOS-5286 Repository: mesos Description --- The previous commit added authorization handling to `ProcessBase::visit`, so the authorization handlers in the endpoint code can be removed. Diffs - 3rdparty/libprocess/include/process/logging.hpp 651cb3736705124bec9e4366c0e7adc5d5b488f0 3rdparty/libprocess/include/process/metrics/metrics.hpp 25e8fcaeb9c71eaa43096165745e79c8198c139a 3rdparty/libprocess/src/logging.cpp ad7aa3aabbfc4a496e7e624a691a72e45c72e35d 3rdparty/libprocess/src/metrics/metrics.cpp 65b58433158c51cebace9b591d4121e8d9a59ecc Diff: https://reviews.apache.org/r/46990/diff/ Testing --- `make check` on OSX. Thanks, Greg Mann
