Re: Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/#review135189 --- Shall we discard this patch in favor of https://reviews.apache.org/r/47736/ ? - Adam B On May 9, 2016, 7:47 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47071/ > --- > > (Updated May 9, 2016, 7:47 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Michael Park. > > > Repository: mesos > > > Description > --- > > The /state and /task endpoints output framework and task level data. > Hence we need to authorize both frameworks and tasks. > > > Diffs > - > > src/authorizer/local/authorizer.cpp > e59c11269670a7ed72b780913971b421ee17f33f > src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > > Diff: https://reviews.apache.org/r/47071/diff/ > > > Testing > --- > > make check (osx) > > > Thanks, > > Joerg Schad > >
Re: Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/#review132290 --- Patch looks great! Reviews applied: [46613, 47068, 47069, 47070, 47071] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 9, 2016, 2:47 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47071/ > --- > > (Updated May 9, 2016, 2:47 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Michael Park. > > > Repository: mesos > > > Description > --- > > The /state and /task endpoints output framework and task level data. > Hence we need to authorize both frameworks and tasks. > > > Diffs > - > > src/authorizer/local/authorizer.cpp > e59c11269670a7ed72b780913971b421ee17f33f > src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > > Diff: https://reviews.apache.org/r/47071/diff/ > > > Testing > --- > > make check (osx) > > > Thanks, > > Joerg Schad > >
Re: Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/ --- (Updated May 9, 2016, 2:47 p.m.) Review request for mesos, Adam B, Alexander Rojas, and Michael Park. Repository: mesos Description --- The /state and /task endpoints output framework and task level data. Hence we need to authorize both frameworks and tasks. Diffs (updated) - src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 Diff: https://reviews.apache.org/r/47071/diff/ Testing --- make check (osx) Thanks, Joerg Schad
Re: Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/#review132113 --- Patch looks great! Reviews applied: [46613, 47068, 47069, 47070, 47071] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 6, 2016, 8:35 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47071/ > --- > > (Updated May 6, 2016, 8:35 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Michael Park. > > > Repository: mesos > > > Description > --- > > The /state and /task endpoints output framework and task level data. > Hence we need to authorize both frameworks and tasks. > > > Diffs > - > > src/authorizer/local/authorizer.cpp > e59c11269670a7ed72b780913971b421ee17f33f > src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > > Diff: https://reviews.apache.org/r/47071/diff/ > > > Testing > --- > > make check (osx) > > > Thanks, > > Joerg Schad > >
Review Request 47071: Added framework/task filtering to /state and /tasks endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47071/ --- Review request for mesos, Adam B, Alexander Rojas, and Michael Park. Repository: mesos Description --- The /state and /task endpoints output framework and task level data. Hence we need to authorize both frameworks and tasks. Diffs - src/authorizer/local/authorizer.cpp e59c11269670a7ed72b780913971b421ee17f33f src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 Diff: https://reviews.apache.org/r/47071/diff/ Testing --- make check (osx) Thanks, Joerg Schad
