Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-24 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- (Updated May 24, 2016, 10:18 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review134466 --- src/docker/spec.cpp (lines 207 - 230)

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review134454 --- Ship it! Ship It! - Jie Yu On May 13, 2016, 8:49 p.m.,

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-13 Thread Guangya Liu
> On 五月 12, 2016, 12:44 p.m., Guangya Liu wrote: > > src/docker/spec.cpp, lines 226-230 > > > > > > Does there are any possiblity that there are duplicat labels in > > `config` and `container_config`? If so, how to

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-13 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- (Updated May 13, 2016, 1:49 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-13 Thread Gilbert Song
> On May 12, 2016, 5:44 a.m., Guangya Liu wrote: > > src/docker/spec.cpp, lines 226-230 > > > > > > Does there are any possiblity that there are duplicat labels in > > `config` and `container_config`? If so, how to

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review132880 --- src/docker/spec.cpp (line 171)

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-11 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- (Updated May 11, 2016, 8:56 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-10 Thread Gilbert Song
> On May 10, 2016, 5:50 p.m., Kevin Klues wrote: > > src/docker/spec.cpp, line 164 > > > > > > Is there always a "config" and a "container_config" (below) in every > > image? If not, won't we error out

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-10 Thread Gilbert Song
> On May 10, 2016, 5:50 p.m., Kevin Klues wrote: > > src/docker/spec.cpp, line 164 > > > > > > Is there always a "config" and a "container_config" (below) in every > > image? If not, won't we error out

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/#review132576 --- src/docker/spec.cpp (line 164)

Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-10 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47199/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin