Re: Review Request 47208: Made logic for executor path consistent across example frameworks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/#review133294
---




src/examples/test_framework.cpp (line 197)


This was added by jpeach for making tests run from the installation 
directory, IIRC. Does this not break that?


- Vinod Kone


On May 11, 2016, 12:44 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47208/
> ---
> 
> (Updated May 11, 2016, 12:44 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change makes the logic for retrieving the path to
> the executor consistent across all example frameworks.
> - The test framework was using the `MESOS_HELPER_DIR` while
> other examples used to rely on `MESOS_BUILD_DIR`.
> - The test HTTP framework used to append `src` to the executor
> path that is not needed strictly. The other examples don't do it.
> 
> 
> Diffs
> -
> 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
> 
> Diff: https://reviews.apache.org/r/47208/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 47208: Made logic for executor path consistent across example frameworks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/#review132582
---


Ship it!




Ship It!

- Vinod Kone


On May 11, 2016, 12:44 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47208/
> ---
> 
> (Updated May 11, 2016, 12:44 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change makes the logic for retrieving the path to
> the executor consistent across all example frameworks.
> - The test framework was using the `MESOS_HELPER_DIR` while
> other examples used to rely on `MESOS_BUILD_DIR`.
> - The test HTTP framework used to append `src` to the executor
> path that is not needed strictly. The other examples don't do it.
> 
> 
> Diffs
> -
> 
>   src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
>   src/examples/test_http_framework.cpp 
> db0463d894e9f2fb964781d16f8c622ce8a507a5 
> 
> Diff: https://reviews.apache.org/r/47208/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 47208: Made logic for executor path consistent across example frameworks.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47208/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

This trivial change makes the logic for retrieving the path to
the executor consistent across all example frameworks.
- The test framework was using the `MESOS_HELPER_DIR` while
other examples used to rely on `MESOS_BUILD_DIR`.
- The test HTTP framework used to append `src` to the executor
path that is not needed strictly. The other examples don't do it.


Diffs
-

  src/examples/test_framework.cpp 79113fbe47fda0912f0b01dc10429495a96ba8b8 
  src/examples/test_http_framework.cpp db0463d894e9f2fb964781d16f8c622ce8a507a5 

Diff: https://reviews.apache.org/r/47208/diff/


Testing
---

make check


Thanks,

Anand Mazumdar