Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-25 Thread Joseph Wu
> On May 25, 2016, 6:25 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152 > > > > > > Is this change absolutely necessary for the ticket? > > Jie Yu wrote: > Oh, i see that being

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-25 Thread Jie Yu
> On May 26, 2016, 1:25 a.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152 > > > > > > Is this change absolutely necessary for the ticket? > > Jie Yu wrote: > Oh, i see that being

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-25 Thread Jie Yu
> On May 26, 2016, 1:25 a.m., Jie Yu wrote: > > 3rdparty/libprocess/src/subprocess.cpp, lines 150-152 > > > > > > Is this change absolutely necessary for the ticket? Oh, i see that being useful in the following

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/#review134892 --- 3rdparty/libprocess/src/subprocess.cpp (lines 150 - 152)

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-23 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/#review134503 --- Ship it! Ship It! - Kapil Arya On May 16, 2016, 2:01 p.m.,

Re: Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/ --- (Updated May 16, 2016, 11:01 a.m.) Review request for mesos, Adam B, Artem

Review Request 47214: Replaced subprocess flag stringification with flags.toVector().

2016-05-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47214/ --- Review request for mesos, Adam B, Artem Harutyunyan, Jie Yu, and Kapil Arya.