Re: Review Request 47381: Fixed agent to properly handle killTask of unregistered executor.

2016-05-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47381/#review133260
---



Patch looks great!

Reviews applied: [47381]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 14, 2016, 12:28 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47381/
> ---
> 
> (Updated May 14, 2016, 12:28 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5380
> https://issues.apache.org/jira/browse/MESOS-5380
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The agent now shuts down the executor during registration if it does not
> have any queued tasks (e.g., framework sent a killTask before
> registration).
> 
> Note that if the executor doesn't register at all, it will be cleaned up
> anyway after the registration timeout value.
> 
> Also, note that this doesn't handle the case where the agent restarts
> after processing the killTask() but before cleaning up the executor.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 7c870396b4d6804bfda6169d76d136e95cd839f5 
>   src/tests/slave_tests.cpp 3ec670aa75790417ec8b7b96cfdb787492b104e1 
> 
> Diff: https://reviews.apache.org/r/47381/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> The new test failed w/o the code change.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>



Review Request 47381: Fixed agent to properly handle killTask of unregistered executor.

2016-05-13 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47381/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-5380
https://issues.apache.org/jira/browse/MESOS-5380


Repository: mesos


Description
---

The agent now shuts down the executor during registration if it does not
have any queued tasks (e.g., framework sent a killTask before
registration).

Note that if the executor doesn't register at all, it will be cleaned up
anyway after the registration timeout value.

Also, note that this doesn't handle the case where the agent restarts
after processing the killTask() but before cleaning up the executor.


Diffs
-

  src/slave/slave.cpp 7c870396b4d6804bfda6169d76d136e95cd839f5 
  src/tests/slave_tests.cpp 3ec670aa75790417ec8b7b96cfdb787492b104e1 

Diff: https://reviews.apache.org/r/47381/diff/


Testing
---

make check

The new test failed w/o the code change.


Thanks,

Vinod Kone