Re: Review Request 47412: Windows: Use Winsock class in slave and containerizer.

2016-05-23 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47412/
---

(Updated May 23, 2016, 12:39 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Use Winsock class in slave and containerizer.


Diffs (updated)
-

  src/slave/containerizer/mesos/main.cpp 
ed0c6cd0721b9f486be056d2ae62cbccf53bc834 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 

Diff: https://reviews.apache.org/r/47412/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47412: Windows: Use Winsock class in slave and containerizer.

2016-05-16 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47412/#review133432
---


Fix it, then Ship it!





src/slave/containerizer/mesos/main.cpp (lines 20 - 22)


before the stout block please.



src/slave/main.cpp (line 32)


separate block as it's a subdirectory.


- Joris Van Remoortere


On May 16, 2016, 2:04 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47412/
> ---
> 
> (Updated May 16, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Use Winsock class in slave and containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/main.cpp 
> ed0c6cd0721b9f486be056d2ae62cbccf53bc834 
>   src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
> 
> Diff: https://reviews.apache.org/r/47412/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47412: Windows: Use Winsock class in slave and containerizer.

2016-05-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47412/#review133367
---



Patch looks great!

Reviews applied: [47052, 47053, 47221, 47054, 41632, 47168, 47169, 47386, 
47387, 47388, 47389, 47390, 47391, 47403, 47404, 47409, 47410, 47411, 47412]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 16, 2016, 2:04 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47412/
> ---
> 
> (Updated May 16, 2016, 2:04 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Use Winsock class in slave and containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/main.cpp 
> ed0c6cd0721b9f486be056d2ae62cbccf53bc834 
>   src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 
> 
> Diff: https://reviews.apache.org/r/47412/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 47412: Windows: Use Winsock class in slave and containerizer.

2016-05-16 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47412/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Repository: mesos


Description
---

Windows: Use Winsock class in slave and containerizer.


Diffs
-

  src/slave/containerizer/mesos/main.cpp 
ed0c6cd0721b9f486be056d2ae62cbccf53bc834 
  src/slave/main.cpp fee46bafc88f8cdade868aab8c0fee79b8d2fb6d 

Diff: https://reviews.apache.org/r/47412/diff/


Testing
---


Thanks,

Alex Clemmer