Re: Review Request 47447: Some cleanup for watchdog logic in subprocess.

2016-05-27 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47447/#review135344
---


Ship it!




Ship It!

- Jie Yu


On May 17, 2016, 8:39 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47447/
> ---
> 
> (Updated May 17, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some cleanup for watchdog logic in subprocess.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> 19799644990132d15d3e6543112742dca92c1f67 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> dde958b252eae75563003ec15087b4231beb285a 
> 
> Diff: https://reviews.apache.org/r/47447/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 47447: Some cleanup for watchdog logic in subprocess.

2016-05-17 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47447/#review133553
---



Patch looks great!

Reviews applied: [47447]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 17, 2016, 8:39 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47447/
> ---
> 
> (Updated May 17, 2016, 8:39 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Some cleanup for watchdog logic in subprocess.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> 19799644990132d15d3e6543112742dca92c1f67 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> dde958b252eae75563003ec15087b4231beb285a 
> 
> Diff: https://reviews.apache.org/r/47447/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Review Request 47447: Some cleanup for watchdog logic in subprocess.

2016-05-17 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47447/
---

Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
---

Some cleanup for watchdog logic in subprocess.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
19799644990132d15d3e6543112742dca92c1f67 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
dde958b252eae75563003ec15087b4231beb285a 

Diff: https://reviews.apache.org/r/47447/diff/


Testing
---

make
make check


Thanks,

Guangya Liu