Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/#review133888 --- Ship it! Kevin and I went over this and made some adjustments, mostly related to variable naming, some comment changes, a few changes to the code style. - Benjamin Mahler On May 19, 2016, 5:38 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47485/ > --- > > (Updated May 19, 2016, 5:38 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5398 > https://issues.apache.org/jira/browse/MESOS-5398 > > > Repository: mesos > > > Description > --- > > Added utility for parsing ld.so.cache on linux. > > > Diffs > - > > configure.ac 63ea028fa89ba8e164e98226fc7ddcffd8b045c8 > src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 > src/linux/ldcache.hpp PRE-CREATION > src/linux/ldcache.cpp PRE-CREATION > src/tests/ldcache_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/47485/diff/ > > > Testing > --- > > GTEST_FILTER="LdcacheTest.Parse" make check -j > > > Thanks, > > Kevin Klues > >
Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/ --- (Updated May 19, 2016, 5:38 a.m.) Review request for mesos and Benjamin Mahler. Changes --- Updated to only compile ldcache_tests.cpp when compiling for Nvidia GPU support (because of an external dependence on libelf headers). We also added a check in configure.ac to make sure we have these headers installed when building with Nvidia GPU support in general. Bugs: MESOS-5398 https://issues.apache.org/jira/browse/MESOS-5398 Repository: mesos Description --- Added utility for parsing ld.so.cache on linux. Diffs (updated) - configure.ac 63ea028fa89ba8e164e98226fc7ddcffd8b045c8 src/Makefile.am 571d2a5cca1f78ed55131fe830e8b17f2bcf0471 src/linux/ldcache.hpp PRE-CREATION src/linux/ldcache.cpp PRE-CREATION src/tests/ldcache_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47485/diff/ Testing --- GTEST_FILTER="LdcacheTest.Parse" make check -j Thanks, Kevin Klues
Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/ --- (Updated May 18, 2016, 8:21 p.m.) Review request for mesos and Benjamin Mahler. Changes --- Updated the test based on changes to the ELF parsing library. Bugs: MESOS-5398 https://issues.apache.org/jira/browse/MESOS-5398 Repository: mesos Description --- Added utility for parsing ld.so.cache on linux. Diffs (updated) - src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 src/linux/ldcache.hpp PRE-CREATION src/linux/ldcache.cpp PRE-CREATION src/tests/ldcache_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47485/diff/ Testing --- GTEST_FILTER="LdcacheTest.Parse" make check -j Thanks, Kevin Klues
Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/ --- (Updated May 18, 2016, 3:40 a.m.) Review request for mesos and Benjamin Mahler. Changes --- Forgot to update header when updating cpp file. Bugs: MESOS-5398 https://issues.apache.org/jira/browse/MESOS-5398 Repository: mesos Description --- Added utility for parsing ld.so.cache on linux. Diffs (updated) - src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 src/linux/ldcache.hpp PRE-CREATION src/linux/ldcache.cpp PRE-CREATION src/tests/ldcache_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47485/diff/ Testing --- GTEST_FILTER="LdcacheTest.Parse" make check -j Thanks, Kevin Klues
Re: Review Request 47485: Added utility for parsing ld.so.cache on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/ --- (Updated May 18, 2016, 3:21 a.m.) Review request for mesos and Benjamin Mahler. Changes --- Updated based on changes to the ELF parsing utility. Bugs: MESOS-5398 https://issues.apache.org/jira/browse/MESOS-5398 Repository: mesos Description --- Added utility for parsing ld.so.cache on linux. Diffs (updated) - src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 src/linux/ldcache.hpp PRE-CREATION src/linux/ldcache.cpp PRE-CREATION src/tests/ldcache_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47485/diff/ Testing --- GTEST_FILTER="LdcacheTest.Parse" make check -j Thanks, Kevin Klues
Review Request 47485: Added utility for parsing ld.so.cache on linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47485/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5398 https://issues.apache.org/jira/browse/MESOS-5398 Repository: mesos Description --- Added utility for parsing ld.so.cache on linux. Diffs - src/Makefile.am ce5245883f3d2661812272702c0d2060513b6d88 src/linux/ldcache.hpp PRE-CREATION src/linux/ldcache.cpp PRE-CREATION src/tests/ldcache_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/47485/diff/ Testing --- GTEST_FILTER="LdcacheTest.Parse" make check -j Thanks, Kevin Klues
