Re: Review Request 47518: Added test case for no volume and no checkpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47518/#review167324 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On June 18, 2016, 4:41 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47518/ > --- > > (Updated June 18, 2016, 4:41 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5266 > https://issues.apache.org/jira/browse/MESOS-5266 > > > Repository: mesos > > > Description > --- > > Added test case for no volume and no checkpoint. > > > Diffs > - > > src/tests/containerizer/docker_volume_isolator_tests.cpp > effa687f0b05124e4e5229dfd6490e796aea4048 > > > Diff: https://reviews.apache.org/r/47518/diff/2/ > > > Testing > --- > > make > make check > > [ RUN ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes > [ OK ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes > (384 ms) > > > Thanks, > > Guangya Liu > >
Re: Review Request 47518: Added test case for no volume and no checkpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47518/#review138388 --- Patch looks great! Reviews applied: [48900, 36383, 47518] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 18, 2016, 4:41 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47518/ > --- > > (Updated June 18, 2016, 4:41 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5266 > https://issues.apache.org/jira/browse/MESOS-5266 > > > Repository: mesos > > > Description > --- > > Added test case for no volume and no checkpoint. > > > Diffs > - > > src/tests/containerizer/docker_volume_isolator_tests.cpp > effa687f0b05124e4e5229dfd6490e796aea4048 > > Diff: https://reviews.apache.org/r/47518/diff/ > > > Testing > --- > > make > make check > > [ RUN ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes > [ OK ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes > (384 ms) > > > Thanks, > > Guangya Liu > >
Re: Review Request 47518: Added test case for no volume and no checkpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47518/ --- (Updated 六月 18, 2016, 4:41 a.m.) Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5266 https://issues.apache.org/jira/browse/MESOS-5266 Repository: mesos Description --- Added test case for no volume and no checkpoint. Diffs (updated) - src/tests/containerizer/docker_volume_isolator_tests.cpp effa687f0b05124e4e5229dfd6490e796aea4048 Diff: https://reviews.apache.org/r/47518/diff/ Testing --- make make check [ RUN ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes [ OK ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes (384 ms) Thanks, Guangya Liu
Re: Review Request 47518: Added test case for no volume and no checkpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47518/#review133753 --- Patch looks great! Reviews applied: [46428, 36383, 47518] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 18, 2016, 5:59 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47518/ > --- > > (Updated May 18, 2016, 5:59 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-5266 > https://issues.apache.org/jira/browse/MESOS-5266 > > > Repository: mesos > > > Description > --- > > Added test case for no volume and no checkpoint. > > > Diffs > - > > src/tests/containerizer/docker_volume_isolator_tests.cpp > c524f42743bf08ee54f1cbb083d0d3c85a8b70c9 > > Diff: https://reviews.apache.org/r/47518/diff/ > > > Testing > --- > > make > make check > > [ RUN ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes > [ OK ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes > (384 ms) > > > Thanks, > > Guangya Liu > >
Review Request 47518: Added test case for no volume and no checkpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47518/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-5266 https://issues.apache.org/jira/browse/MESOS-5266 Repository: mesos Description --- Added test case for no volume and no checkpoint. Diffs - src/tests/containerizer/docker_volume_isolator_tests.cpp c524f42743bf08ee54f1cbb083d0d3c85a8b70c9 Diff: https://reviews.apache.org/r/47518/diff/ Testing --- make make check [ RUN ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes [ OK ] DockerVolumeIsolatorTest.ROOT_CommandTaskNoRootfsWithoutVolumes (384 ms) Thanks, Guangya Liu
