Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133897 --- Fix it, then Ship it! I'll take care of the outstanding issues

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-19 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133898 --- Fix it, then Ship it! src/slave/http.cpp

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133820 --- Patch looks great! Reviews applied: [47530] Passed command:

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- (Updated May 18, 2016, 8 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- (Updated May 18, 2016, 7:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133797 --- Patch looks great! Reviews applied: [47530] Passed command:

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133734 --- src/slave/http.cpp (line 788)

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Alexander Rukletsov
> On May 18, 2016, 12:55 p.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 787 > > > > > > Please call `authorizeEndpoint` as soon as possible, i.e. after the > > endpoint has been extracted from the URL. > >

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- (Updated May 18, 2016, 12:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/#review133719 --- src/slave/http.cpp (line 756)

Review Request 47530: Added authorization to agent's '/containers' endpoint.

2016-05-18 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47530/ --- Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, Jan Schlicht,