Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/#review135588 --- Fix it, then Ship it! src/slave/containerizer/mesos/isolators/

Re: Review Request 47536: Agent: Added Windows isolators.

> On May 24, 2016, 11:27 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/isolators/filesystem/windows.hpp, lines 31-38 > > > > > > Can you explain what we are accomplishing here by making this prox

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 28, 2016, 7:38 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47536: Agent: Added Windows isolators.

> On May 24, 2016, 11:27 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp, line 130 > > > > > > Why? > > What about the code below isn't supported on windows? We

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 28, 2016, 3:17 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 28, 2016, 2:22 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 26, 2016, 2:53 p.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/#review134660 --- src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (lin

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- (Updated May 19, 2016, 2:50 a.m.) Review request for mesos, Daniel Pravat, Arte

Re: Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/#review133775 --- Bad patch! Reviews applied: [47536, 47472, 47471, 47470, 47469, 4

Review Request 47536: Agent: Added Windows isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47536/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere