Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-30 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/#review135588
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/filesystem/windows.cpp (lines 17 - 22)


I don't think you use these?



src/slave/containerizer/mesos/isolators/filesystem/windows.cpp (lines 30 - 36)


I don't think you use these?


- Joris Van Remoortere


On May 28, 2016, 7:38 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47536/
> ---
> 
> (Updated May 28, 2016, 7:38 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3620
> https://issues.apache.org/jira/browse/MESOS-3683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Added Windows isolators.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9eabd781763adba39b60526c1b4a7d99b3f1 
>   src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> 01ab1793d3d5469e6590617326b5e77e56bc7c50 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> 227505a70a440f15e68ac001878bcf25610db45f 
>   src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 9e803f6ae55f09f7e871c60531acce16ebd5e8fe 
>   src/usage/main.cpp ab3bb233caf6ba02af1b306dcf31d2b9ba6e322a 
>   src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
>   src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 
> 
> Diff: https://reviews.apache.org/r/47536/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-28 Thread Alex Clemmer 


> On May 24, 2016, 11:27 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/windows.hpp, lines 31-38
> > 
> >
> > Can you explain what we are accomplishing here by making this proxy?

This is starting of the Windows File Isolator for future development.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/#review134660
---


On May 28, 2016, 7:38 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47536/
> ---
> 
> (Updated May 28, 2016, 7:38 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3620
> https://issues.apache.org/jira/browse/MESOS-3683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Added Windows isolators.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9eabd781763adba39b60526c1b4a7d99b3f1 
>   src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> 01ab1793d3d5469e6590617326b5e77e56bc7c50 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> 227505a70a440f15e68ac001878bcf25610db45f 
>   src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 9e803f6ae55f09f7e871c60531acce16ebd5e8fe 
>   src/usage/main.cpp ab3bb233caf6ba02af1b306dcf31d2b9ba6e322a 
>   src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
>   src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 
> 
> Diff: https://reviews.apache.org/r/47536/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-28 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/
---

(Updated May 28, 2016, 7:38 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3620
https://issues.apache.org/jira/browse/MESOS-3683


Repository: mesos


Description
---

Agent: Added Windows isolators.


Diffs (updated)
-

  src/CMakeLists.txt 9eabd781763adba39b60526c1b4a7d99b3f1 
  src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
01ab1793d3d5469e6590617326b5e77e56bc7c50 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/posix.hpp 
227505a70a440f15e68ac001878bcf25610db45f 
  src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
9e803f6ae55f09f7e871c60531acce16ebd5e8fe 
  src/usage/main.cpp ab3bb233caf6ba02af1b306dcf31d2b9ba6e322a 
  src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
  src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 

Diff: https://reviews.apache.org/r/47536/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-28 Thread Alex Clemmer 


> On May 24, 2016, 11:27 p.m., Joris Van Remoortere wrote:
> > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp, line 130
> > 
> >
> > Why?
> > What about the code below isn't supported on windows?

We excluded just the code using os::chown.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/#review134660
---


On May 28, 2016, 3:17 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47536/
> ---
> 
> (Updated May 28, 2016, 3:17 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3620
> https://issues.apache.org/jira/browse/MESOS-3683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Added Windows isolators.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 9eabd781763adba39b60526c1b4a7d99b3f1 
>   src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> 01ab1793d3d5469e6590617326b5e77e56bc7c50 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> 227505a70a440f15e68ac001878bcf25610db45f 
>   src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 9e803f6ae55f09f7e871c60531acce16ebd5e8fe 
>   src/usage/main.cpp ab3bb233caf6ba02af1b306dcf31d2b9ba6e322a 
>   src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
>   src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 
> 
> Diff: https://reviews.apache.org/r/47536/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-27 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/
---

(Updated May 28, 2016, 3:17 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3620
https://issues.apache.org/jira/browse/MESOS-3683


Repository: mesos


Description
---

Agent: Added Windows isolators.


Diffs (updated)
-

  src/CMakeLists.txt 9eabd781763adba39b60526c1b4a7d99b3f1 
  src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
01ab1793d3d5469e6590617326b5e77e56bc7c50 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/posix.hpp 
227505a70a440f15e68ac001878bcf25610db45f 
  src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
9e803f6ae55f09f7e871c60531acce16ebd5e8fe 
  src/usage/main.cpp ab3bb233caf6ba02af1b306dcf31d2b9ba6e322a 
  src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
  src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 

Diff: https://reviews.apache.org/r/47536/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-27 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/
---

(Updated May 28, 2016, 2:22 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Changes
---

master rebased


Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3620
https://issues.apache.org/jira/browse/MESOS-3683


Repository: mesos


Description
---

Agent: Added Windows isolators.


Diffs (updated)
-

  src/CMakeLists.txt 9eabd781763adba39b60526c1b4a7d99b3f1 
  src/Makefile.am f1bd5e6e5515535c2aaf9ea8b205f4e8c7096ec5 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
01ab1793d3d5469e6590617326b5e77e56bc7c50 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
cb42d83a779c63c9ae25bbe72292aba3fe4cb8c9 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/posix.hpp 
227505a70a440f15e68ac001878bcf25610db45f 
  src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
  src/usage/main.cpp ab3bb233caf6ba02af1b306dcf31d2b9ba6e322a 
  src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
  src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 

Diff: https://reviews.apache.org/r/47536/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-26 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/
---

(Updated May 26, 2016, 2:53 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3620
https://issues.apache.org/jira/browse/MESOS-3683


Repository: mesos


Description
---

Agent: Added Windows isolators.


Diffs (updated)
-

  src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
  src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/posix.hpp 
227505a70a440f15e68ac001878bcf25610db45f 
  src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 
  src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
  src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 

Diff: https://reviews.apache.org/r/47536/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-24 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/#review134660
---




src/slave/containerizer/mesos/isolators/filesystem/posix.cpp (line 130)


Why?
What about the code below isn't supported on windows?



src/slave/containerizer/mesos/isolators/filesystem/windows.hpp (lines 31 - 38)


Can you explain what we are accomplishing here by making this proxy?


- Joris Van Remoortere


On May 19, 2016, 2:50 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47536/
> ---
> 
> (Updated May 19, 2016, 2:50 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3620
> https://issues.apache.org/jira/browse/MESOS-3683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Added Windows isolators.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> c6cea98e16f2bdea2da0220c235468080bbcd17b 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 01c0ad6dbb6d509e62e769365586b3d23dcb240d 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> 227505a70a440f15e68ac001878bcf25610db45f 
>   src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
>   src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 
>   src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
>   src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 
> 
> Diff: https://reviews.apache.org/r/47536/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-18 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/
---

(Updated May 19, 2016, 2:50 a.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3619, MESOS-3620 and MESOS-3683
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3620
https://issues.apache.org/jira/browse/MESOS-3683


Repository: mesos


Description
---

Agent: Added Windows isolators.


Diffs
-

  src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
  src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/posix.hpp 
227505a70a440f15e68ac001878bcf25610db45f 
  src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 
  src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
  src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 

Diff: https://reviews.apache.org/r/47536/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47536: Agent: Added Windows isolators.

2016-05-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/#review133775
---



Bad patch!

Reviews applied: [47536, 47472, 47471, 47470, 47469, 47468, 47412, 47411, 
47410, 47409, 47404, 47403, 47391, 47390, 47389, 47388, 47387, 47386, 47169, 
47168, 41632, 47054, 47221, 47053, 47052]

Failed command: ./support/apply-review.sh -n -r 47471

Error:
2016-05-18 18:07:23 URL:https://reviews.apache.org/r/47471/diff/raw/ 
[5804/5804] -> "47471.patch" [1]
error: patch failed: src/exec/exec.cpp:595
error: src/exec/exec.cpp: patch does not apply
error: patch failed: src/executor/executor.cpp:154
error: src/executor/executor.cpp: patch does not apply
error: patch failed: src/launcher/fetcher.cpp:443
error: src/launcher/fetcher.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13151/console

- Mesos ReviewBot


On May 18, 2016, 1:41 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47536/
> ---
> 
> (Updated May 18, 2016, 1:41 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-3619 and MESOS-3620
> https://issues.apache.org/jira/browse/MESOS-3619
> https://issues.apache.org/jira/browse/MESOS-3620
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Agent: Added Windows isolators.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
>   src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
> c6cea98e16f2bdea2da0220c235468080bbcd17b 
>   src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
> 01c0ad6dbb6d509e62e769365586b3d23dcb240d 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/posix.hpp 
> 227505a70a440f15e68ac001878bcf25610db45f 
>   src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
>   src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 
>   src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
>   src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 
> 
> Diff: https://reviews.apache.org/r/47536/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 47536: Agent: Added Windows isolators.

2016-05-18 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47536/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-3619 and MESOS-3620
https://issues.apache.org/jira/browse/MESOS-3619
https://issues.apache.org/jira/browse/MESOS-3620


Repository: mesos


Description
---

Agent: Added Windows isolators.


Diffs
-

  src/CMakeLists.txt e0c538d9e6542fbe279bfbf6f20172e4c611c859 
  src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 
  src/slave/containerizer/mesos/isolators/filesystem/posix.hpp 
c6cea98e16f2bdea2da0220c235468080bbcd17b 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
01c0ad6dbb6d509e62e769365586b3d23dcb240d 
  src/slave/containerizer/mesos/isolators/filesystem/windows.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/filesystem/windows.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/posix.hpp 
227505a70a440f15e68ac001878bcf25610db45f 
  src/slave/containerizer/mesos/isolators/windows.hpp PRE-CREATION 
  src/usage/main.cpp 731acb69900b6fc2bb7bd19cccd78aafb0cc 
  src/usage/usage.hpp 2e1996a78c617c2559ef882ebede5c8aab6f899f 
  src/usage/usage.cpp 3b19682e67372b81484eacddbab78c2e5eda3c5b 

Diff: https://reviews.apache.org/r/47536/diff/


Testing
---


Thanks,

Alex Clemmer