Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Kevin Klues
> On May 23, 2016, 7:56 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/containerizer.hpp, lines 64-68 > > > > > > Hm.. it seems more like the default set of resources would not include > > the flags. > >

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Kevin Klues
> On May 23, 2016, 7:56 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/composing.cpp, lines 276-280 > > > > > > How about "managed" and "manage" instead of "enumerated" and > > "enumerate" here? It seems

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47707/#review134414 --- src/slave/containerizer/composing.cpp (lines 276 - 280)

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Kevin Klues
> On May 23, 2016, 10:03 a.m., Guangya Liu wrote: > > Did not go to detail for now, but post one early comment: It is suggested > > that every patch should be atomic, which means that you should merge your > > patch https://reviews.apache.org/r/47708/ to this one to make sure the > > test

Re: Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47707/#review134329 --- Did not go to detail for now, but post one early comment: It is

Review Request 47707: Refactored resource enumeration for containerizers and isolators.

2016-05-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47707/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5256