Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-06-08 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review136730 --- Ship it! Thanks! - Benjamin Mahler On May 23, 2016, 6:11

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/ --- (Updated May 23, 2016, 6:11 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread Kevin Klues
Can you also link the issue back to the review in JIRA: Workflow -> Post Review https://issues.apache.org/jira/browse/MESOS-5436 On Mon, May 23, 2016 at 11:02 AM, haosdent huang wrote: > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 5:29 p.m., Kevin Klues wrote: > > Looks good. Just curous -- how did you upload the pictures to the testing > > section? Is there someway to make them smaller next time? LoL I upload it via jira and use `![](image_link)` to show it in reviewboard. Seems reviewboard don't

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review134406 --- Patch looks great! Reviews applied: [47719] Passed command:

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 4:16 p.m., Kevin Klues wrote: > > I don't think we want to remove the headers. Instead, we want to add > > column bodies with 0 values or "N/A" ass appropriate. > > haosdent huang wrote: > Got it, already updated. Let me upload the screenshots as well. Just update the

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
> On May 23, 2016, 4:16 p.m., Kevin Klues wrote: > > I don't think we want to remove the headers. Instead, we want to add > > column bodies with 0 values or "N/A" ass appropriate. Got it, already updated. Let me upload the screenshots as well. - haosdent

Re: Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/#review134337 --- Patch looks great! Reviews applied: [47719] Passed command:

Review Request 47719: Removed invalid gpu statistics columns in framework data tables.

2016-05-23 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47719/ --- Review request for mesos, Benjamin Mahler, Kevin Klues, and Vinod Kone. Bugs: