Re: Review Request 51954: Removed the "strict" flag from the registry operation interface.

2016-09-16 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51954/
---

(Updated Sept. 16, 2016, 7:37 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Add comment to unused parameters.


Bugs: MESOS-5951
https://issues.apache.org/jira/browse/MESOS-5951


Repository: mesos


Description
---

This flag is now ignored by all registry operations, so this should
not result in a functional change.


Diffs (updated)
-

  src/master/maintenance.hpp 87fbb2a54d62fa30e421e122a104dc38d2022124 
  src/master/maintenance.cpp 7da61c7f17fbc8594b7f0dd684bf9e577874796b 
  src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 
  src/master/quota.hpp 3cb194aa9f032d5d18cb2dcc09c672b11e8d56eb 
  src/master/quota.cpp bec6bd9342152905b3b21dcc60ec52fba1dbd8ec 
  src/master/registrar.hpp c39dd1b5430084e51376143b5441db346e85a153 
  src/master/registrar.cpp 7aa0148cf75f8f580e55ddaac4a7df28b984b17a 
  src/master/weights.hpp 80d13694a8a97449963dde52476736fa986a1a2e 
  src/master/weights.cpp 4942ac88b8e27741ef9b4e1fe0d82ab788bae883 

Diff: https://reviews.apache.org/r/51954/diff/


Testing
---

`make check` on OSX and Linux.


Thanks,

Neil Conway

Re: Review Request 51954: Removed the "strict" flag from the registry operation interface.

2016-09-16 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51954/#review149240
---




src/master/maintenance.cpp (line 45)


looks like our style is to add a comment about the unused parameter.

https://github.com/apache/mesos/blob/master/src/slave/slave.hpp#L487


- Vinod Kone


On Sept. 16, 2016, 12:59 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51954/
> ---
> 
> (Updated Sept. 16, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5951
> https://issues.apache.org/jira/browse/MESOS-5951
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag is now ignored by all registry operations, so this should
> not result in a functional change.
> 
> 
> Diffs
> -
> 
>   src/master/maintenance.hpp 87fbb2a54d62fa30e421e122a104dc38d2022124 
>   src/master/maintenance.cpp 7da61c7f17fbc8594b7f0dd684bf9e577874796b 
>   src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 
>   src/master/quota.hpp 3cb194aa9f032d5d18cb2dcc09c672b11e8d56eb 
>   src/master/quota.cpp bec6bd9342152905b3b21dcc60ec52fba1dbd8ec 
>   src/master/registrar.hpp c39dd1b5430084e51376143b5441db346e85a153 
>   src/master/registrar.cpp 7aa0148cf75f8f580e55ddaac4a7df28b984b17a 
>   src/master/weights.hpp 80d13694a8a97449963dde52476736fa986a1a2e 
>   src/master/weights.cpp 4942ac88b8e27741ef9b4e1fe0d82ab788bae883 
> 
> Diff: https://reviews.apache.org/r/51954/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX and Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 51954: Removed the "strict" flag from the registry operation interface.

2016-09-16 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51954/#review149233
---


Ship it!




Ship It!

- Vinod Kone


On Sept. 16, 2016, 12:59 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51954/
> ---
> 
> (Updated Sept. 16, 2016, 12:59 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-5951
> https://issues.apache.org/jira/browse/MESOS-5951
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag is now ignored by all registry operations, so this should
> not result in a functional change.
> 
> 
> Diffs
> -
> 
>   src/master/maintenance.hpp 87fbb2a54d62fa30e421e122a104dc38d2022124 
>   src/master/maintenance.cpp 7da61c7f17fbc8594b7f0dd684bf9e577874796b 
>   src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 
>   src/master/quota.hpp 3cb194aa9f032d5d18cb2dcc09c672b11e8d56eb 
>   src/master/quota.cpp bec6bd9342152905b3b21dcc60ec52fba1dbd8ec 
>   src/master/registrar.hpp c39dd1b5430084e51376143b5441db346e85a153 
>   src/master/registrar.cpp 7aa0148cf75f8f580e55ddaac4a7df28b984b17a 
>   src/master/weights.hpp 80d13694a8a97449963dde52476736fa986a1a2e 
>   src/master/weights.cpp 4942ac88b8e27741ef9b4e1fe0d82ab788bae883 
> 
> Diff: https://reviews.apache.org/r/51954/diff/
> 
> 
> Testing
> ---
> 
> `make check` on OSX and Linux.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 51954: Removed the "strict" flag from the registry operation interface.

2016-09-16 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51954/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5951
https://issues.apache.org/jira/browse/MESOS-5951


Repository: mesos


Description
---

This flag is now ignored by all registry operations, so this should
not result in a functional change.


Diffs
-

  src/master/maintenance.hpp 87fbb2a54d62fa30e421e122a104dc38d2022124 
  src/master/maintenance.cpp 7da61c7f17fbc8594b7f0dd684bf9e577874796b 
  src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879 
  src/master/quota.hpp 3cb194aa9f032d5d18cb2dcc09c672b11e8d56eb 
  src/master/quota.cpp bec6bd9342152905b3b21dcc60ec52fba1dbd8ec 
  src/master/registrar.hpp c39dd1b5430084e51376143b5441db346e85a153 
  src/master/registrar.cpp 7aa0148cf75f8f580e55ddaac4a7df28b984b17a 
  src/master/weights.hpp 80d13694a8a97449963dde52476736fa986a1a2e 
  src/master/weights.cpp 4942ac88b8e27741ef9b4e1fe0d82ab788bae883 

Diff: https://reviews.apache.org/r/51954/diff/


Testing
---

`make check` on OSX and Linux.


Thanks,

Neil Conway