Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52011/#review150126 --- Fix it, then Ship it! src/slave/containerizer/mesos/launch.cpp

Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52011/ --- (Updated Sept. 23, 2016, 2:07 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-18 Thread Jie Yu
> On Sept. 18, 2016, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 250 > > > > > > fork is linux specific. Please guard all pre_exec_commands with ifdef > > linux. > > Jie Yu wrote: >

Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-18 Thread Kevin Klues
> On Sept. 18, 2016, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 250 > > > > > > fork is linux specific. Please guard all pre_exec_commands with ifdef > > linux. > > Jie Yu wrote: >

Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-18 Thread Jie Yu
> On Sept. 18, 2016, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 250 > > > > > > fork is linux specific. Please guard all pre_exec_commands with ifdef > > linux. > > Jie Yu wrote: >

Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-18 Thread Jie Yu
> On Sept. 18, 2016, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 250 > > > > > > fork is linux specific. Please guard all pre_exec_commands with ifdef > > linux. If we want to keep

Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52011/#review149398 --- src/slave/containerizer/mesos/launch.cpp (lines 264 - 265)

Re: Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52011/#review149397 --- src/slave/containerizer/mesos/launch.cpp (line 246)

Review Request 52011: Updated launch helper to avoid initializing libprocess.

2016-09-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52011/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6075 https:/