Re: Review Request 52016: Replaces Hook::None() by {} in Mesos [2/2].

2016-09-21 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52016/#review149841
---


Ship it!




Ship It!

- Jie Yu


On Sept. 18, 2016, 7:48 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52016/
> ---
> 
> (Updated Sept. 18, 2016, 7:48 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaces Hook::None() by {} in Mesos.
> 
> 
> Diffs
> -
> 
>   src/launcher/posix/executor.cpp 7c40ebebb983b7977526fee123bf07c86fbb5e50 
>   src/linux/perf.cpp 16a30eac9d346b14f2245128003866b9894bb94a 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> 2b2c6cf2ba35b48e17a169e7a65380889c311266 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 5b9d5aaeb008e9b102e86736c9312db0b3266d34 
>   src/slave/containerizer/mesos/launcher.hpp 
> 61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
> 
> Diff: https://reviews.apache.org/r/52016/diff/
> 
> 
> Testing
> ---
> 
> sudo make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 52016: Replaces Hook::None() by {} in Mesos [2/2].

2016-09-18 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52016/#review149416
---


Ship it!




Ship It!

- Qian Zhang


On Sept. 19, 2016, 3:48 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52016/
> ---
> 
> (Updated Sept. 19, 2016, 3:48 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaces Hook::None() by {} in Mesos.
> 
> 
> Diffs
> -
> 
>   src/launcher/posix/executor.cpp 7c40ebebb983b7977526fee123bf07c86fbb5e50 
>   src/linux/perf.cpp 16a30eac9d346b14f2245128003866b9894bb94a 
>   src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
> 2b2c6cf2ba35b48e17a169e7a65380889c311266 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 5b9d5aaeb008e9b102e86736c9312db0b3266d34 
>   src/slave/containerizer/mesos/launcher.hpp 
> 61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 
> 
> Diff: https://reviews.apache.org/r/52016/diff/
> 
> 
> Testing
> ---
> 
> sudo make check + internal ci
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 52016: Replaces Hook::None() by {} in Mesos [2/2].

2016-09-18 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52016/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Replaces Hook::None() by {} in Mesos.


Diffs
-

  src/launcher/posix/executor.cpp 7c40ebebb983b7977526fee123bf07c86fbb5e50 
  src/linux/perf.cpp 16a30eac9d346b14f2245128003866b9894bb94a 
  src/slave/containerizer/mesos/isolators/docker/volume/driver.cpp 
2b2c6cf2ba35b48e17a169e7a65380889c311266 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
5b9d5aaeb008e9b102e86736c9312db0b3266d34 
  src/slave/containerizer/mesos/launcher.hpp 
61c2e84a3cebc308a8a65e536fa07fa1cf8f5838 

Diff: https://reviews.apache.org/r/52016/diff/


Testing
---

sudo make check + internal ci


Thanks,

Joerg Schad