Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-29 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review150867
---


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 22, 2016, 9:44 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 22, 2016, 9:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging
> the cluster setup and hence we decided they should be generally
> available as their helpfulnes by far outwages their noise given that
> we call these only during initializing.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-22 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review150090
---


Ship it!




- Benjamin Bannier


On Sept. 22, 2016, 11:44 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 22, 2016, 11:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging
> the cluster setup and hence we decided they should be generally
> available as their helpfulnes by far outwages their noise given that
> we call these only during initializing.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-22 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review150055
---


Ship it!




Ship It!

- Joris Van Remoortere


On Sept. 22, 2016, 9:44 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 22, 2016, 9:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging
> the cluster setup and hence we decided they should be generally
> available as their helpfulnes by far outwages their noise given that
> we call these only during initializing.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-22 Thread Till Toenshoff 


> On Sept. 20, 2016, 1:28 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/openssl.cpp, line 289
> > 
> >
> > Can you see if there is any other valuable information in the 
> > initialization routine that might be of value when a user posts a JIRA 
> > issue to help identify the code paths their system went through?
> > Might be a good time to do a full review of the logging in this 
> > function rather than just up a few levels.
> > 
> > You have been debugging many scenarios so I think you are in a unique 
> > position to do this!
> > Thanks Till!

Totally correct and I have at least one more thing coming up;
- detection of SSL encrypted content when non SSL was expected -- we talked 
about that in the past


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review149594
---


On Sept. 22, 2016, 9:26 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 22, 2016, 9:26 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging
> the cluster setup and hence we decided they should be generally
> available as their helpfulnes by far outwages their noise given that
> we call these only during initializing.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-22 Thread Till Toenshoff 


> On Sept. 20, 2016, 1:28 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/openssl.cpp, line 485
> > 
> >
> > Why not this one?
> 
> Till Toenshoff wrote:
> As mentioned in https://reviews.apache.org/r/52031/#comment217242 the 
> results of `X509_get_default_cert_file()` are not what we seem to hope for 
> here.

Added another review to this chain which fixes the above.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review149594
---


On Sept. 22, 2016, 9:26 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 22, 2016, 9:26 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging
> the cluster setup and hence we decided they should be generally
> available as their helpfulnes by far outwages their noise given that
> we call these only during initializing.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-22 Thread Till Toenshoff 


> On Sept. 20, 2016, 1:28 a.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/src/openssl.cpp, line 485
> > 
> >
> > Why not this one?

As mentioned in https://reviews.apache.org/r/52031/#comment217242 the results 
of `X509_get_default_cert_file()` are not what we seem to hope for here.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review149594
---


On Sept. 22, 2016, 9:26 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 22, 2016, 9:26 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging
> the cluster setup and hence we decided they should be generally
> available as their helpfulnes by far outwages their noise given that
> we call these only during initializing.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-22 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/
---

(Updated Sept. 22, 2016, 9:26 a.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Changes
---

Addressed review comments.


Bugs: MESOS-5320
https://issues.apache.org/jira/browse/MESOS-5320


Repository: mesos


Description (updated)
---

The logging messages in question prove to be very useful for debugging
the cluster setup and hence we decided they should be generally
available as their helpfulnes by far outwages their noise given that
we call these only during initializing.


Diffs (updated)
-

  3rdparty/libprocess/src/openssl.cpp c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 

Diff: https://reviews.apache.org/r/52033/diff/


Testing
---

make check && functional testing


Thanks,

Till Toenshoff

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-19 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review149594
---




3rdparty/libprocess/src/openssl.cpp (line 289)


Can you see if there is any other valuable information in the 
initialization routine that might be of value when a user posts a JIRA issue to 
help identify the code paths their system went through?
Might be a good time to do a full review of the logging in this function 
rather than just up a few levels.

You have been debugging many scenarios so I think you are in a unique 
position to do this!
Thanks Till!



3rdparty/libprocess/src/openssl.cpp (line 446)


Why not this one?



3rdparty/libprocess/src/openssl.cpp (line 475)


Why not this one?



3rdparty/libprocess/src/openssl.cpp (line 478)


Why not this one?



3rdparty/libprocess/src/openssl.cpp (line 485)


Why not this one?


- Joris Van Remoortere


On Sept. 19, 2016, 1:50 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 19, 2016, 1:50 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging the
> cluster setup and hence we decided they should be generally available as their
> noise by far outwages their helpfulnes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-19 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review149525
---


Ship it!




This isn't noisy since it only happens once.  Might be somewhat noisy in tests, 
but that's OK.

- Joseph Wu


On Sept. 19, 2016, 6:50 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 19, 2016, 6:50 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging the
> cluster setup and hence we decided they should be generally available as their
> noise by far outwages their helpfulnes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/#review149473
---



Patch looks great!

Reviews applied: [52031, 52033]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 19, 2016, 1:50 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52033/
> ---
> 
> (Updated Sept. 19, 2016, 1:50 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Joseph Wu.
> 
> 
> Bugs: MESOS-5320
> https://issues.apache.org/jira/browse/MESOS-5320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The logging messages in question prove to be very useful for debugging the
> cluster setup and hence we decided they should be generally available as their
> noise by far outwages their helpfulnes.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 
> 
> Diff: https://reviews.apache.org/r/52033/diff/
> 
> 
> Testing
> ---
> 
> make check && functional testing
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-19 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/
---

(Updated Sept. 19, 2016, 1:50 p.m.)


Review request for mesos, Joris Van Remoortere and Joseph Wu.


Summary (updated)
-

Escalated some openssl logs from VLOG to INFO.


Bugs: MESOS-5320
https://issues.apache.org/jira/browse/MESOS-5320


Repository: mesos


Description (updated)
---

The logging messages in question prove to be very useful for debugging the
cluster setup and hence we decided they should be generally available as their
noise by far outwages their helpfulnes.


Diffs
-

  3rdparty/libprocess/src/openssl.cpp c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 

Diff: https://reviews.apache.org/r/52033/diff/


Testing
---

make check && functional testing


Thanks,

Till Toenshoff

Review Request 52033: Escalated some openssl logs from VLOG to INFO.

2016-09-19 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52033/
---

Review request for mesos, Joris Van Remoortere and Joseph Wu.


Bugs: MESOS-5320
https://issues.apache.org/jira/browse/MESOS-5320


Repository: mesos


Description
---

The logging messages in question prove to be very useful for debugging the
cluster setup and hence we decided they should be generally available as their
noise by far outwages their helpfulnes.


Diffs
-

  3rdparty/libprocess/src/openssl.cpp c09cdc89509e4e4ca4c8a0f4fb0a57156a3a6091 

Diff: https://reviews.apache.org/r/52033/diff/


Testing
---

make check && functional testing


Thanks,

Till Toenshoff