Re: Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52034/#review151428
---


Ship it!




LGTM, although I'm no JS expert.


src/webui/master/static/js/controllers.js (lines 404 - 406)


Anything else we'd want to do instead for unauthorized users? I guess we'll 
just show empty/zero cluster metrics? That's better than the continuous error 
dialog at least.


- Adam B


On Sept. 19, 2016, 6:45 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52034/
> ---
> 
> (Updated Sept. 19, 2016, 6:45 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disables the dialog showing a connection error in the WebUI if the
> returned error code is either _401 Unauthorized_ or _403 Forbidden_.
> 
> Showing a connection error is missleading in the latter cases, while
> it also rendered the WebUI unusable since the dialog would show
> over and over again.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52034/diff/
> 
> 
> Testing
> ---
> 
> manual tests and `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52034/#review149481
---



Patch looks great!

Reviews applied: [52034]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 19, 2016, 1:45 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52034/
> ---
> 
> (Updated Sept. 19, 2016, 1:45 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Disables the dialog showing a connection error in the WebUI if the
> returned error code is either _401 Unauthorized_ or _403 Forbidden_.
> 
> Showing a connection error is missleading in the latter cases, while
> it also rendered the WebUI unusable since the dialog would show
> over and over again.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/controllers.js 
> 29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 
> 
> Diff: https://reviews.apache.org/r/52034/diff/
> 
> 
> Testing
> ---
> 
> manual tests and `make check`
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Review Request 52034: Disabled error dialog in WebUI when user is unauthorized to see metrics.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52034/
---

Review request for mesos and Adam B.


Repository: mesos


Description
---

Disables the dialog showing a connection error in the WebUI if the
returned error code is either _401 Unauthorized_ or _403 Forbidden_.

Showing a connection error is missleading in the latter cases, while
it also rendered the WebUI unusable since the dialog would show
over and over again.


Diffs
-

  src/webui/master/static/js/controllers.js 
29a5a1c8754cc2fb934854750d6dfb04f1eaeae4 

Diff: https://reviews.apache.org/r/52034/diff/


Testing
---

manual tests and `make check`


Thanks,

Alexander Rojas