Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review150279
---


Ship it!




Ship It!

- Joseph Wu


On Sept. 23, 2016, 4:59 p.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 23, 2016, 4:59 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread Mao Geng 


> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote:
> > 3rdparty/stout/tests/os_tests.cpp, line 691
> > 
> >
> > Let's call this variable `expected_gids`.

Done


> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote:
> > 3rdparty/stout/tests/os_tests.cpp, line 695
> > 
> >
> > We don't actually include `std::sort` in the headers, so this shouldn't 
> > be able to compile...
> > 
> > Either way, you should fully qualify this function.
> 
> Mao Geng wrote:
> Agree it should be fully qualified. However, last diff didn't fail to 
> compile - I suspect a header file with "using namespace std" is included by 
> accident.

Done


> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote:
> > 3rdparty/stout/tests/os_tests.cpp, line 700
> > 
> >
> > No need to clear this vector, especially since it won't be re-used.

Done


- Mao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review149936
---


On Sept. 23, 2016, 11:59 p.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 23, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread Mao Geng 


> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote:
> > 3rdparty/stout/tests/os_tests.cpp, lines 697-699
> > 
> >
> > How about `EXPECT_EQ(tokens.get(), expected_gids);` here?
> 
> Mao Geng wrote:
> Not sure if EXPECT_EQ can compare two vectors directly? 
> I saw 
> https://github.com/google/googletest/blob/master/googletest/docs/Primer.md 
> has an example:  
> ```
> for (int i = 0; i < x.size(); ++i) {
>   EXPECT_EQ(x[i], y[i]) << "Vectors x and y differ at index " << i;
> }
> ```
> 
> Mao Geng wrote:
> Just tested EXPECT_EQ can compare two vectors perfectly. Thanks @haosdent 
> for pointing it out. I am updating the diff

Done


- Mao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review150202
---


On Sept. 23, 2016, 11:59 p.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 23, 2016, 11:59 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread Mao Geng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/
---

(Updated Sept. 23, 2016, 11:59 p.m.)


Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5909
https://issues.apache.org/jira/browse/MESOS-5909


Repository: mesos


Description
---

Fixed OsTest.User test failure due to gids ordering.


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 

Diff: https://reviews.apache.org/r/52048/diff/


Testing
---

Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.


Thanks,

Mao Geng

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread Mao Geng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/
---

(Updated Sept. 23, 2016, 11:43 p.m.)


Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5909
https://issues.apache.org/jira/browse/MESOS-5909


Repository: mesos


Description
---

Fixed OsTest.User test failure due to gids ordering.


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp c2900b8 

Diff: https://reviews.apache.org/r/52048/diff/


Testing
---

Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.


Thanks,

Mao Geng

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread Mao Geng 


> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote:
> > 3rdparty/stout/tests/os_tests.cpp, lines 697-699
> > 
> >
> > How about `EXPECT_EQ(tokens.get(), expected_gids);` here?
> 
> Mao Geng wrote:
> Not sure if EXPECT_EQ can compare two vectors directly? 
> I saw 
> https://github.com/google/googletest/blob/master/googletest/docs/Primer.md 
> has an example:  
> ```
> for (int i = 0; i < x.size(); ++i) {
>   EXPECT_EQ(x[i], y[i]) << "Vectors x and y differ at index " << i;
> }
> ```

Just tested EXPECT_EQ can compare two vectors perfectly. Thanks @haosdent for 
pointing it out. I am updating the diff


- Mao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review150202
---


On Sept. 22, 2016, 7:29 a.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 22, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread Mao Geng 


> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote:
> > 3rdparty/stout/tests/os_tests.cpp, lines 697-699
> > 
> >
> > How about `EXPECT_EQ(tokens.get(), expected_gids);` here?

Not sure if EXPECT_EQ can compare two vectors directly? 
I saw 
https://github.com/google/googletest/blob/master/googletest/docs/Primer.md has 
an example:  
```
for (int i = 0; i < x.size(); ++i) {
  EXPECT_EQ(x[i], y[i]) << "Vectors x and y differ at index " << i;
}
```


- Mao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review150202
---


On Sept. 22, 2016, 7:29 a.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 22, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-23 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review150202
---




3rdparty/stout/tests/os_tests.cpp (lines 697 - 699)


How about `EXPECT_EQ(tokens.get(), expected_gids);` here?


- haosdent huang


On Sept. 22, 2016, 7:29 a.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 22, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review149997
---



Patch looks great!

Reviews applied: [52048]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 22, 2016, 7:29 a.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 22, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-22 Thread Mao Geng 


> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote:
> > Looks sane :)

Thanks for reviewing!


> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote:
> > 3rdparty/stout/tests/os_tests.cpp, line 695
> > 
> >
> > We don't actually include `std::sort` in the headers, so this shouldn't 
> > be able to compile...
> > 
> > Either way, you should fully qualify this function.

Agree it should be fully qualified. However, last diff didn't fail to compile - 
I suspect a header file with "using namespace std" is included by accident.


- Mao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review149936
---


On Sept. 22, 2016, 7:29 a.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 22, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-22 Thread Mao Geng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/
---

(Updated Sept. 22, 2016, 7:29 a.m.)


Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5909
https://issues.apache.org/jira/browse/MESOS-5909


Repository: mesos


Description
---

Fixed OsTest.User test failure due to gids ordering.


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp c2900b8 

Diff: https://reviews.apache.org/r/52048/diff/


Testing
---

Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.


Thanks,

Mao Geng

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-21 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review149936
---



Looks sane :)


3rdparty/stout/tests/os_tests.cpp (line 691)


Let's call this variable `expected_gids`.



3rdparty/stout/tests/os_tests.cpp (line 695)


We don't actually include `std::sort` in the headers, so this shouldn't be 
able to compile...

Either way, you should fully qualify this function.



3rdparty/stout/tests/os_tests.cpp (line 700)


No need to clear this vector, especially since it won't be re-used.


- Joseph Wu


On Sept. 19, 2016, 2:52 p.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 19, 2016, 2:52 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/#review149544
---



Patch looks great!

Reviews applied: [52048]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 19, 2016, 6:42 p.m., Mao Geng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52048/
> ---
> 
> (Updated Sept. 19, 2016, 6:42 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kapil Arya.
> 
> 
> Bugs: MESOS-5909
> https://issues.apache.org/jira/browse/MESOS-5909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed OsTest.User test failure due to gids ordering.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 
> 
> Diff: https://reviews.apache.org/r/52048/diff/
> 
> 
> Testing
> ---
> 
> Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.
> 
> 
> Thanks,
> 
> Mao Geng
> 
>

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-19 Thread Mao Geng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/
---

(Updated Sept. 19, 2016, 6:42 p.m.)


Review request for mesos, Gilbert Song and Kapil Arya.


Bugs: MESOS-5909
https://issues.apache.org/jira/browse/MESOS-5909


Repository: mesos


Description
---

Fixed OsTest.User test failure due to gids ordering.


Diffs
-

  3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 

Diff: https://reviews.apache.org/r/52048/diff/


Testing (updated)
---

Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS.


Thanks,

Mao Geng

Re: Review Request 52048: Fixed OsTest.User test failure due to gids ordering.

2016-09-19 Thread Mao Geng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52048/
---

(Updated Sept. 19, 2016, 6:41 p.m.)


Review request for mesos, Gilbert Song and Kapil Arya.


Bugs: MESOS-5909
https://issues.apache.org/jira/browse/MESOS-5909


Repository: mesos


Description
---

Fixed OsTest.User test failure due to gids ordering.


Diffs
-

  3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 

Diff: https://reviews.apache.org/r/52048/diff/


Testing
---

Just changed the OsTest.User test. `make check` passed


Thanks,

Mao Geng