Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

2016-09-21 Thread Benjamin Mahler 


> On Sept. 19, 2016, 7:24 p.m., Vinod Kone wrote:
> > src/tests/slave_tests.cpp, line 1919
> > 
> >
> > should we call this out in the CHANGELOG? best to create a ticket to 
> > link the reviews.

Filed a ticket here:
https://issues.apache.org/jira/browse/MESOS-6220

Will call this out in the CHANGELOG as an API change.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52054/#review149533
---


On Sept. 19, 2016, 7:15 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52054/
> ---
> 
> (Updated Sept. 19, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously HTTP handler failures lead to a 'Service Unavailble'
> response in libprocess. Now it leads to an 'Internal Server Error'.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 
> 
> Diff: https://reviews.apache.org/r/52054/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

2016-09-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52054/#review149570
---



Patch looks great!

Reviews applied: [52053, 52054]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 19, 2016, 7:15 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52054/
> ---
> 
> (Updated Sept. 19, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously HTTP handler failures lead to a 'Service Unavailble'
> response in libprocess. Now it leads to an 'Internal Server Error'.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 
> 
> Diff: https://reviews.apache.org/r/52054/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

2016-09-19 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52054/#review149533
---


Fix it, then Ship it!





src/tests/slave_tests.cpp (line 1919)


should we call this out in the CHANGELOG? best to create a ticket to link 
the reviews.


- Vinod Kone


On Sept. 19, 2016, 7:15 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52054/
> ---
> 
> (Updated Sept. 19, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously HTTP handler failures lead to a 'Service Unavailble'
> response in libprocess. Now it leads to an 'Internal Server Error'.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 
> 
> Diff: https://reviews.apache.org/r/52054/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 52054: Updated slave test to expect 500 rather than 503 from libprocess.

2016-09-19 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52054/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Previously HTTP handler failures lead to a 'Service Unavailble'
response in libprocess. Now it leads to an 'Internal Server Error'.


Diffs
-

  src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 

Diff: https://reviews.apache.org/r/52054/diff/


Testing
---

make check


Thanks,

Benjamin Mahler