Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop.

2016-09-19 Thread Vinod Kone
> On Sept. 19, 2016, 10:40 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 384 > > > > > > While it's true that this can only be done once, I would vote to keep > > it close to the `if (task.isSome())` loop

Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop.

2016-09-19 Thread Guangya Liu
> On 九月 19, 2016, 10:40 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 384 > > > > > > While it's true that this can only be done once, I would vote to keep > > it close to the `if (task.isSome())` loop

Re: Review Request 52069: Moved `CHECK_NE` out of the offers loop.

2016-09-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52069/#review149558 --- src/cli/execute.cpp (line 384)

Review Request 52069: Moved `CHECK_NE` out of the offers loop.

2016-09-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52069/ --- Review request for mesos, Abhishek Dasgupta and Vinod Kone. Repository: mesos