Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

2016-09-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/#review150119 --- This test is causing segfaults for me on master. - Kevin Klues

Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

2016-09-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/ --- (Updated Sept. 23, 2016, 8:17 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

2016-09-21 Thread Vinod Kone
> On Sept. 22, 2016, 1:18 a.m., Vinod Kone wrote: > > i'll fix the typos while committing. actually looks like you need to rebase. - Vinod --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

2016-09-21 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/#review149932 --- Fix it, then Ship it! i'll fix the typos while committing.

Re: Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

2016-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/#review149631 --- Patch looks great! Reviews applied: [46187, 52075] Passed

Review Request 52075: Added the test `HTTPCommandExecutorTest.TerminateWithACK`.

2016-09-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52075/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5276