Re: Review Request 52098: Updated UUID::fromString to not throw an exception on error.

2016-09-20 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52098/#review149758
---


Ship it!




Ship It!

- Vinod Kone


On Sept. 20, 2016, 9:24 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52098/
> ---
> 
> (Updated Sept. 20, 2016, 9:24 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The exception from the string_generator needs to be caught so
> that we can surface a Try to the caller.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/uuid.hpp 
> e638d458c6cb4aaee121a903bb381ccfdeae3fad 
>   3rdparty/stout/tests/uuid_tests.cpp 
> 8f28fcf491e43e87ddd5b54737fd5aef0f6db0a6 
> 
> Diff: https://reviews.apache.org/r/52098/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 52098: Updated UUID::fromString to not throw an exception on error.

2016-09-20 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52098/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

The exception from the string_generator needs to be caught so
that we can surface a Try to the caller.


Diffs
-

  3rdparty/stout/include/stout/uuid.hpp 
e638d458c6cb4aaee121a903bb381ccfdeae3fad 
  3rdparty/stout/tests/uuid_tests.cpp 8f28fcf491e43e87ddd5b54737fd5aef0f6db0a6 

Diff: https://reviews.apache.org/r/52098/diff/


Testing
---

Added tests.


Thanks,

Benjamin Mahler