Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

[Benjamin Mahler]

> On Sept. 21, 2016, 2:39 a.m., Guangya Liu wrote:
> > src/Makefile.am, line 2121
> > 
> >
> > Just a question here: for the new added test files for agent, do we 
> > want to continue name it as slave_xxx_tests.cpp or agent_xxx_tests.cpp?

Ideally a sweep of the slave file names would be great, but understandably we 
may have to do it incrementally.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52100/#review149783
---


On Sept. 20, 2016, 9:28 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52100/
> ---
> 
> (Updated Sept. 20, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2449
> https://issues.apache.org/jira/browse/MESOS-2449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f 
>   src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
>   src/tests/slave_validation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52100/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

[Benjamin Mahler]

> On Sept. 20, 2016, 11:48 p.m., Vinod Kone wrote:
> > src/slave/validation.cpp, lines 117-127
> > 
> >
> > so `UUID::fromBytes()` (used for status update uuids) doesn't impose a 
> > restriction on the version but we want to impose version restriction here?

My thinking is that since it isn't reasonable to use other versions:

* 1 has some uniqueness issues now that processors have become faster, and so 
has some workarounds.
* 2 is not explicitly defined in the UUID specficiation.
* 3 is based on names within a namespace, not clear how that could be 
applicable here.
* 5 has the same issue as 3, but uses SHA-1 instead of MD5.

Rather than have the user have to work this out, we might as well require 
version 4 and relax it if a use case arises (doubtful). IMHO if we want 
executors to generate UUIDs for status updates, we should probably also require 
version 4.


> On Sept. 20, 2016, 11:48 p.m., Vinod Kone wrote:
> > src/slave/validation.cpp, lines 117-127
> > 
> >
> > I would flip the order of these two.

Ah yes, this evolved poorly.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52100/#review149761
---


On Sept. 20, 2016, 9:28 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52100/
> ---
> 
> (Updated Sept. 20, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2449
> https://issues.apache.org/jira/browse/MESOS-2449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f 
>   src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
>   src/tests/slave_validation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52100/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52100/#review149803
---



Bad patch!

Reviews applied: [52100, 52099, 52098, 52057, 52056, 52055, 52054, 52053]

Failed command: ./support/apply-review.sh -n -r 52056

Error:
2016-09-21 10:20:02 URL:https://reviews.apache.org/r/52056/diff/raw/ 
[24286/24286] -> "52056.patch" [1]
error: patch failed: src/slave/containerizer/docker.cpp:1795
error: src/slave/containerizer/docker.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/15345/console

- Mesos ReviewBot


On Sept. 20, 2016, 9:28 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52100/
> ---
> 
> (Updated Sept. 20, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2449
> https://issues.apache.org/jira/browse/MESOS-2449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f 
>   src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
>   src/tests/slave_validation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52100/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52100/#review149783
---




src/Makefile.am (line 2121)


Just a question here: for the new added test files for agent, do we want to 
continue name it as slave_xxx_tests.cpp or agent_xxx_tests.cpp?



src/slave/validation.cpp (line 112)


s/ContainerID/`ContainerID`

Ditto here and elsewhere.



src/slave/validation.cpp (line 129)


s/ContainerID/`ContainerID`


- Guangya Liu


On 九月 20, 2016, 9:28 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52100/
> ---
> 
> (Updated 九月 20, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2449
> https://issues.apache.org/jira/browse/MESOS-2449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f 
>   src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
>   src/tests/slave_validation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52100/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52100/#review149761
---


Fix it, then Ship it!




LGTM modulo the names as mentioned in the earlier review.


src/slave/validation.cpp (lines 117 - 127)


so `UUID::fromBytes()` (used for status update uuids) doesn't impose a 
restriction on the version but we want to impose version restriction here?



src/slave/validation.cpp (lines 117 - 127)


I would flip the order of these two.



src/tests/slave_validation_tests.cpp (line 20)


new line?



src/tests/slave_validation_tests.cpp (line 42)


shouldn't these be backticks? here and everywhere else?


- Vinod Kone


On Sept. 20, 2016, 9:28 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52100/
> ---
> 
> (Updated Sept. 20, 2016, 9:28 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2449
> https://issues.apache.org/jira/browse/MESOS-2449
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f 
>   src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
>   src/tests/slave_validation_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52100/diff/
> 
> 
> Testing
> ---
> 
> Added tests.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 52100: Added validation of NESTED_CONTAINER_* calls in the agent API.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52100/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-2449
https://issues.apache.org/jira/browse/MESOS-2449


Repository: mesos


Description
---

See summary.


Diffs
-

  src/Makefile.am b6b64bc93980cb81fc50380835865af1f6e4e59f 
  src/slave/validation.cpp a9f318214182a87783a985cd8495a0ec00c95378 
  src/tests/slave_validation_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/52100/diff/


Testing
---

Added tests.


Thanks,

Benjamin Mahler