Re: Review Request 52177: Added support for CNI networks for `--task_group`.

2016-09-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52177/#review150151 --- Ship it! Ship It! - Vinod Kone On Sept. 22, 2016, 9:48

Re: Review Request 52177: Added support for CNI networks for `--task_group`.

2016-09-22 Thread Vinod Kone
> On Sept. 23, 2016, 5:16 a.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 468-478 > > > > > > I don't follow this change. Can the TaskGroupInfo JSON not contain the > > NetworkInfos? Why do have to specify

Re: Review Request 52177: Added support for CNI networks for `--task_group`.

2016-09-22 Thread Avinash sridharan
> On Sept. 23, 2016, 5:16 a.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 468-478 > > > > > > I don't follow this change. Can the TaskGroupInfo JSON not contain the > > NetworkInfos? Why do have to specify

Re: Review Request 52177: Added support for CNI networks for `--task_group`.

2016-09-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52177/#review150143 --- src/cli/execute.cpp (lines 468 - 478)

Review Request 52177: Added support for CNI networks for `--task_group`.

2016-09-22 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52177/ --- Review request for mesos, Jie Yu and Vinod Kone. Bugs: MESOS-6096