Re: Review Request 52186: Fixed build error for HTTPCommandExecutorTest.TerminateWithACK.

2016-09-22 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52186/#review150124
---


Ship it!




Ship It!

- Joseph Wu


On Sept. 22, 2016, 7:34 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52186/
> ---
> 
> (Updated Sept. 22, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed build error for HTTPCommandExecutorTest.TerminateWithACK.
> 
> 
> Diffs
> -
> 
>   src/tests/command_executor_tests.cpp 
> 2bc466761d48b3c8024b754cc561e1e11fe7fe1f 
>   src/tests/mock_slave.hpp 39e836b7671012930ce46e16f40b248803cbb999 
> 
> Diff: https://reviews.apache.org/r/52186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> ```
> ./bin/mesos-tests.sh --gtest_filter="HTTPCommandExecutorTest.TerminateWithACK"
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from HTTPCommandExecutorTest
> [ RUN  ] HTTPCommandExecutorTest.TerminateWithACK
> [   OK ] HTTPCommandExecutorTest.TerminateWithACK (1566 ms)
> [--] 1 test from HTTPCommandExecutorTest (1567 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (1736 ms total)
> [  PASSED  ] 1 test.
> 
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Review Request 52186: Fixed build error for HTTPCommandExecutorTest.TerminateWithACK.

2016-09-22 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52186/
---

Review request for mesos and Vinod Kone.


Repository: mesos


Description
---

Fixed build error for HTTPCommandExecutorTest.TerminateWithACK.


Diffs
-

  src/tests/command_executor_tests.cpp 2bc466761d48b3c8024b754cc561e1e11fe7fe1f 
  src/tests/mock_slave.hpp 39e836b7671012930ce46e16f40b248803cbb999 

Diff: https://reviews.apache.org/r/52186/diff/


Testing
---

make check

```
./bin/mesos-tests.sh --gtest_filter="HTTPCommandExecutorTest.TerminateWithACK"
[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from HTTPCommandExecutorTest
[ RUN  ] HTTPCommandExecutorTest.TerminateWithACK
[   OK ] HTTPCommandExecutorTest.TerminateWithACK (1566 ms)
[--] 1 test from HTTPCommandExecutorTest (1567 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (1736 ms total)
[  PASSED  ] 1 test.

```


Thanks,

Guangya Liu