Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-11-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/#review156783 --- This change should be replaced by these two:

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-11-23 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Nov. 23, 2016, 5:13 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-11-13 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Nov. 14, 2016, 5:47 a.m.) Review request for mesos, Alex Naparu,

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-10-07 Thread Joseph Wu
> On Sept. 23, 2016, 6:42 p.m., Joseph Wu wrote: > > It's a bit odd that this function signature has a double. We should > > investigate why and decided whether or not we should change the interface > > to `uint64_t`. I double checked where we use the multiplication/division operators for

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-09-28 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- (Updated Sept. 29, 2016, 4:33 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-09-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/#review150283 --- It's a bit odd that this function signature has a double. We

Review Request 52192: Fixed VC warnings in bytes.hpp.

2016-09-22 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Repository: mesos