Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

2016-12-02 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52210/#review157861
---


Ship it!




Ship It!

- Joseph Wu


On Nov. 13, 2016, 9:47 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52210/
> ---
> 
> (Updated Nov. 13, 2016, 9:47 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, 
> Joseph Wu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed warnings in `getcwd.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/windows.hpp 
> 3782aa0f5c8636fef3cd47e78be0b9860b735a02 
> 
> Diff: https://reviews.apache.org/r/52210/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

2016-11-13 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52210/
---

(Updated Nov. 14, 2016, 5:47 a.m.)


Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph 
Wu, and Michael Park.


Repository: mesos


Description
---

Fixed warnings in `getcwd.hpp`.


Diffs (updated)
-

  3rdparty/stout/include/stout/windows.hpp 
3782aa0f5c8636fef3cd47e78be0b9860b735a02 

Diff: https://reviews.apache.org/r/52210/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 52210: Fixed warnings in getcwd.hpp.

2016-09-28 Thread Daniel Pravat 


> On Sept. 29, 2016, 12:32 a.m., Joseph Wu wrote:
> > 3rdparty/stout/include/stout/os/getcwd.hpp, line 27
> > 
> >
> > This doesn't seem correct.
> > 
> > `getcwd()` on Posix is:
> > ```
> > char *getcwd(char *buf, size_t size);
> > ```
> > 
> > On Windows:
> > ```
> > char *_getcwd(char *buffer, int maxlen);
> > ```
> > 
> > So we should be changing the `getcwd()` wrapper in `stout/windows.hpp`.

Missed our re-definition.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52210/#review150791
---


On Sept. 23, 2016, 4:48 a.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52210/
> ---
> 
> (Updated Sept. 23, 2016, 4:48 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed warnings in getcwd.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/getcwd.hpp 
> 63ecc98326a4ba9d78eb0bcec18407c3f4a76de3 
> 
> Diff: https://reviews.apache.org/r/52210/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 52210: Fixed warnings in `getcwd.hpp`.

2016-09-28 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52210/
---

(Updated Sept. 29, 2016, 3:32 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Summary (updated)
-

Fixed warnings in `getcwd.hpp`.


Repository: mesos


Description (updated)
---

Fixed warnings in `getcwd.hpp`.


Diffs (updated)
-

  3rdparty/stout/include/stout/windows.hpp 
3782aa0f5c8636fef3cd47e78be0b9860b735a02 

Diff: https://reviews.apache.org/r/52210/diff/


Testing
---


Thanks,

Daniel Pravat

Re: Review Request 52210: Fixed warnings in getcwd.hpp.

2016-09-28 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52210/#review150791
---




3rdparty/stout/include/stout/os/getcwd.hpp (line 27)


This doesn't seem correct.

`getcwd()` on Posix is:
```
char *getcwd(char *buf, size_t size);
```

On Windows:
```
char *_getcwd(char *buffer, int maxlen);
```

So we should be changing the `getcwd()` wrapper in `stout/windows.hpp`.


- Joseph Wu


On Sept. 22, 2016, 9:48 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52210/
> ---
> 
> (Updated Sept. 22, 2016, 9:48 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed warnings in getcwd.hpp.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/getcwd.hpp 
> 63ecc98326a4ba9d78eb0bcec18407c3f4a76de3 
> 
> Diff: https://reviews.apache.org/r/52210/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Review Request 52210: Fixed warnings in getcwd.hpp.

2016-09-22 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52210/
---

Review request for mesos, Alex Clemmer and Joseph Wu.


Repository: mesos


Description
---

Fixed warnings in getcwd.hpp.


Diffs
-

  3rdparty/stout/include/stout/os/getcwd.hpp 
63ecc98326a4ba9d78eb0bcec18407c3f4a76de3 

Diff: https://reviews.apache.org/r/52210/diff/


Testing
---


Thanks,

Daniel Pravat