Re: Review Request 52778: Added Windows support to Agent test environment harness.

2016-12-02 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52778/
---

(Updated Dec. 3, 2016, 12:06 a.m.)


Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
---

Added Windows support to Agent test harness.

Several files required to run any of the Agent tests currently can't be
compiled by MSVC. The individual reasons are mostly small, incidental
details -- missing headers, assumption of POSIX paths, and so on. The
one big exception to this is that the `main` function of the test binary
itself isn't setting up the WSA stack and making sure the right SEH
callbacks are present.

This commit addresses all of these issues.


Diffs (updated)
-

  src/sched/sched.cpp 6a44d57ba5771568571b9bdbed3b87d0c35ff345 
  src/scheduler/scheduler.cpp d545c9f0c0f507810dd873e3e6b5a665ff7f7584 
  src/tests/containerizer.hpp 9d99ac172e5e8c27461af3ab1230f6dc9181ec7b 
  src/tests/environment.cpp 970136f98c601c4fbc71e8ffbf506bebe89c3658 
  src/tests/main.cpp e5990e2e141c188de7fe1b8d5f2d274560c04df4 
  src/tests/mock_docker.hpp a24f87c87bbfac96a123204883fb1771f6993d89 
  src/tests/utils.cpp 0a9e5a867a46795f01fcf7030f50581b5ef1341f 

Diff: https://reviews.apache.org/r/52778/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 52778: Added Windows support to Agent test environment harness.

2016-12-02 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52778/#review157837
---


Fix it, then Ship it!





src/tests/utils.cpp (lines 38 - 42)


The binary output directory for these were changed to match the autotools 
build.  The changes to this file should no longer be necessary.


- Joseph Wu


On Oct. 12, 2016, 3:49 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52778/
> ---
> 
> (Updated Oct. 12, 2016, 3:49 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Windows support to Agent test harness.
> 
> Several files required to run any of the Agent tests currently can't be
> compiled by MSVC. The individual reasons are mostly small, incidental
> details -- missing headers, assumption of POSIX paths, and so on. The
> one big exception to this is that the `main` function of the test binary
> itself isn't setting up the WSA stack and making sure the right SEH
> callbacks are present.
> 
> This commit addresses all of these issues.
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 9d1b5ce2e1a179b2e6ea212d99d8d7fe72a0793a 
>   src/scheduler/scheduler.cpp e282d419119dd1f01e170acf5cc2c6175b59791d 
>   src/tests/containerizer.hpp 940c4146f4e854a6b1b9ccaba5687e76d5723cba 
>   src/tests/environment.cpp 970136f98c601c4fbc71e8ffbf506bebe89c3658 
>   src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 
>   src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 
>   src/tests/utils.cpp fc004a9c567898ffbc38a42cc2340dd57347a829 
> 
> Diff: https://reviews.apache.org/r/52778/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 52778: Added Windows support to Agent test environment harness.

2016-10-12 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52778/
---

Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
---

Added Windows support to Agent test harness.

Several files required to run any of the Agent tests currently can't be
compiled by MSVC. The individual reasons are mostly small, incidental
details -- missing headers, assumption of POSIX paths, and so on. The
one big exception to this is that the `main` function of the test binary
itself isn't setting up the WSA stack and making sure the right SEH
callbacks are present.

This commit addresses all of these issues.


Diffs
-

  src/sched/sched.cpp 9d1b5ce2e1a179b2e6ea212d99d8d7fe72a0793a 
  src/scheduler/scheduler.cpp e282d419119dd1f01e170acf5cc2c6175b59791d 
  src/tests/containerizer.hpp 940c4146f4e854a6b1b9ccaba5687e76d5723cba 
  src/tests/environment.cpp 970136f98c601c4fbc71e8ffbf506bebe89c3658 
  src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 
  src/tests/mock_docker.hpp 1bf09c8dba020b421526b650523c879fb87380f8 
  src/tests/utils.cpp fc004a9c567898ffbc38a42cc2340dd57347a829 

Diff: https://reviews.apache.org/r/52778/diff/


Testing
---


Thanks,

Alex Clemmer