Re: Review Request 52780: Added input and output functions for v1::CapabilityInfo.

2016-10-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52780/#review153162
---


Ship it!




Made some adjustment while commit.

- Jie Yu


On Oct. 12, 2016, 12:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52780/
> ---
> 
> (Updated Oct. 12, 2016, 12:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added input and output functions for v1::CapabilityInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.hpp f17145857355d7b85d70b6452bf1f89bf54edbac 
>   src/common/parse.hpp 62a333cc1f287439c761aa6f0c7f0bf7ade4a818 
>   src/v1/mesos.cpp 0f88abaf49117e844eeb3654edabeeba3862a0eb 
> 
> Diff: https://reviews.apache.org/r/52780/diff/
> 
> 
> Testing
> ---
> 
> * confirmed identically configured unversioned and `v1` `CapabilityInfo`s 
> produce identical output,
> * used and tested implicitly as part of https://reviews.apache.org/r/52741/
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52780: Added input and output functions for v1::CapabilityInfo.

2016-10-18 Thread Benjamin Bannier 


> On Oct. 18, 2016, 12:11 a.m., Jie Yu wrote:
> > src/v1/mesos.cpp, lines 517-533
> > 
> >
> > Can you follow the same impl in v0?

In fact I would have liked to use the same tooling v0 uses here, but could find 
`JSON::protobuf` being used at all in this file. It feels like that would help 
to avoid things getting out of sync should the proto definitions evolve. Do you 
know why we cannot do this?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52780/#review152970
---


On Oct. 12, 2016, 2:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52780/
> ---
> 
> (Updated Oct. 12, 2016, 2:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added input and output functions for v1::CapabilityInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.hpp f17145857355d7b85d70b6452bf1f89bf54edbac 
>   src/common/parse.hpp 62a333cc1f287439c761aa6f0c7f0bf7ade4a818 
>   src/v1/mesos.cpp 0f88abaf49117e844eeb3654edabeeba3862a0eb 
> 
> Diff: https://reviews.apache.org/r/52780/diff/
> 
> 
> Testing
> ---
> 
> * confirmed identically configured unversioned and `v1` `CapabilityInfo`s 
> produce identical output,
> * used and tested implicitly as part of https://reviews.apache.org/r/52741/
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 52780: Added input and output functions for v1::CapabilityInfo.

2016-10-17 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52780/#review152970
---




src/v1/mesos.cpp (lines 517 - 533)


Can you follow the same impl in v0?


- Jie Yu


On Oct. 12, 2016, 12:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52780/
> ---
> 
> (Updated Oct. 12, 2016, 12:49 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added input and output functions for v1::CapabilityInfo.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.hpp f17145857355d7b85d70b6452bf1f89bf54edbac 
>   src/common/parse.hpp 62a333cc1f287439c761aa6f0c7f0bf7ade4a818 
>   src/v1/mesos.cpp 0f88abaf49117e844eeb3654edabeeba3862a0eb 
> 
> Diff: https://reviews.apache.org/r/52780/diff/
> 
> 
> Testing
> ---
> 
> * confirmed identically configured unversioned and `v1` `CapabilityInfo`s 
> produce identical output,
> * used and tested implicitly as part of https://reviews.apache.org/r/52741/
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 52780: Added input and output functions for v1::CapabilityInfo.

2016-10-12 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52780/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added input and output functions for v1::CapabilityInfo.


Diffs
-

  include/mesos/v1/mesos.hpp f17145857355d7b85d70b6452bf1f89bf54edbac 
  src/common/parse.hpp 62a333cc1f287439c761aa6f0c7f0bf7ade4a818 
  src/v1/mesos.cpp 0f88abaf49117e844eeb3654edabeeba3862a0eb 

Diff: https://reviews.apache.org/r/52780/diff/


Testing
---

* confirmed identically configured unversioned and `v1` `CapabilityInfo`s 
produce identical output,
* used and tested implicitly as part of https://reviews.apache.org/r/52741/


Thanks,

Benjamin Bannier